Diagonal TP mass matrices and related changes #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inducer
force-pushed
the
diag-mass-matrix
branch
3 times, most recently
from
f465e46 to
ad5e5ea
Compare
inducer
force-pushed
the
diag-mass-matrix
branch
2 times, most recently
from
511d2b6 to
7e3dc0b
Compare
alexfikl
reviewed
Jun 8, 2024
Collaborator
alexfikl
left a comment
alexfikl
left a comment
There was a problem hiding this comment.
Checked the formulas for the Lobatto weights and everything looks good to me.
Left a few nitpicks, but should be good! Not sure what's with that
alexfikl
reviewed
Jun 8, 2024
Collaborator
|
For some comparison, |
inducer
force-pushed
the
diag-mass-matrix
branch
from
7e3dc0b to
99f5081
Compare
Owner
Author
Thanks! Added that to the code, in case it becomes helpful sometime. |
NB: The actual-Jacobi part of the quadrature is kind of untested right now.
inducer
force-pushed
the
diag-mass-matrix
branch
from
99f5081 to
40e3d9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best read commit-by-commit.