Command history with cursor up in internal shell

[ulope]

When inside the internal shell the cursor-up key just selects the lines in history with no (apparent) useful function.

It would be nice if it could instead access the history (as does ctrl-p/n).

[inducer]

While I understand the request, I fear that that would be inconsistent with how navigation in Urwid works. Under your suggested change, Ctrl-X would likely be the only way to navigate away from the (internal) command line.

[asmeurer]

I find this annoying too. You can navigate history in the internal shell with Ctrl-p / Ctrl-n. Going through the history is useful, especially for long outputs like tracebacks. But I would prefer if the arrow keys defaulted to history.

[inducer]

Hmm, OK. I cold be convinced, if one of you were to produce a PR.

[erik-megarad]

Agree, this is super annoying. It's really messing up my muscle memory.

[ned2]

Perhaps this could be a configurable preference?

up/down going back/forward through shell history is fundamentally hardwired into my expectations of how REPLs work. I'm loving PUDB but this is breaking my brain.

What would be involved in putting together a PR for this?

[asmeurer]

IMO it should just be changed. Should be a simple PR.

[inducer]

Given the overwhelming sentiment on this, I'm on board.

[ned2]

I've created submitted a PR for this at #392. I figured leaving the existing ctrl p/n bindings made sense?