Add emit_declname parameter to _generate_type to match pycparser #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of eliben/pycparser#315, _generate_type() makes emitting the declname configurable. Do the same in ext_c_generator to avoid a TypeError.
tautschnig
added a commit
to tautschnig/fshell-w2t
that referenced
this pull request
Nov 23, 2020
Owner
|
Thanks for your contribution! This looks good to me. To get this merged, could you:
|
Without the preceding patch, the same test would fail with:
```
def visit_TypeDecl(self, n):
> return self._generate_type(n, emit_declname=False)
E TypeError: _generate_type() got an unexpected keyword argument 'emit_declname'
```
Contributor
Author
Thank you for your immediate feedback. Both are now done, in two additional commits. |
Owner
|
Thanks for the quick response. LGTM |
tautschnig
added a commit
to tautschnig/fshell-w2t
that referenced
this pull request
Nov 25, 2020
This reverts commit 0443f78.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of eliben/pycparser#315, _generate_type()
makes emitting the declname configurable. Do the same in ext_c_generator
to avoid a TypeError.