Skip to content

Ga stringifier#237

Merged
inducer merged 4 commits intomainfrom
ga-stringifier
Feb 17, 2026
Merged

Ga stringifier#237
inducer merged 4 commits intomainfrom
ga-stringifier

Conversation

@inducer
Copy link
Owner

@inducer inducer commented Feb 17, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 17, 2026 18:44
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds type annotations to the geometric algebra stringifier infrastructure, improving type safety and resolving type checking errors. The changes standardize the make_stringifier method across the codebase by adding proper type annotations using ParamSpec to represent variable arguments and keyword arguments that can be passed through the mapper chain.

Changes:

  • Added type annotations to make_stringifier methods using ParamSpec[P] to properly type the stringifier's variable arguments
  • Updated geometric algebra StringifyMapper to accept and propagate *args and **kwargs through mapper method calls
  • Fixed method name from stringifier to make_stringifier in _GeometricCalculusExpression for consistency with base class

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
pymbolic/primitives.py Added ParamSpec import and type annotations to make_stringifier method signature
pymbolic/geometric_algebra/primitives.py Renamed stringifier to make_stringifier, added @override decorator and type annotations
pymbolic/geometric_algebra/mapper.py Parameterized StringifyMapper with P and updated map methods to accept and propagate *args and **kwargs
.basedpyright/baseline.json Removed resolved type checking errors related to missing parameter types and unused parameters

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@inducer inducer merged commit f138fcf into main Feb 17, 2026
16 checks passed
@inducer inducer deleted the ga-stringifier branch February 17, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments