Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds type annotations to the geometric algebra stringifier infrastructure, improving type safety and resolving type checking errors. The changes standardize the make_stringifier method across the codebase by adding proper type annotations using ParamSpec to represent variable arguments and keyword arguments that can be passed through the mapper chain.
Changes:
- Added type annotations to
make_stringifiermethods usingParamSpec[P]to properly type the stringifier's variable arguments - Updated geometric algebra
StringifyMapperto accept and propagate*argsand**kwargsthrough mapper method calls - Fixed method name from
stringifiertomake_stringifierin_GeometricCalculusExpressionfor consistency with base class
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pymbolic/primitives.py | Added ParamSpec import and type annotations to make_stringifier method signature |
| pymbolic/geometric_algebra/primitives.py | Renamed stringifier to make_stringifier, added @override decorator and type annotations |
| pymbolic/geometric_algebra/mapper.py | Parameterized StringifyMapper with P and updated map methods to accept and propagate *args and **kwargs |
| .basedpyright/baseline.json | Removed resolved type checking errors related to missing parameter types and unused parameters |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.