Skip to content

Comments

Mesh partition#43

Merged
inducer merged 7 commits intoinducer:mainfrom
kevindugan:mesh-partition
Aug 26, 2022
Merged

Mesh partition#43
inducer merged 7 commits intoinducer:mainfrom
kevindugan:mesh-partition

Conversation

@kevindugan
Copy link
Contributor

@kevindugan kevindugan commented Aug 19, 2022

I'm also interested in the feature outlined in this issue. I've put together a starting point for the associated wrapper.

Some features which may be missing are:

  1. The ability to supply a connectivity consistent with the METIS format (ie flat connectivity and offset vector). Initial implementation only supports list of [list of node indices]; the METIS format is deduced.
  2. Further options handling in the wrapper. Initial implementation uses mostly default options.

Happy to discuss any suggestions.

@inducer
Copy link
Owner

inducer commented Aug 21, 2022

Hmm, odd coinidence. Take a look at #44, which seems to pursue goals relatively similar goals to this PR (IIUC that is). Could the two of you come up with a joint proposal so that we can pursue that? Thanks in advance!

Copy link
Owner

@inducer inducer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few comments below.

@kevindugan
Copy link
Contributor Author

@inducer, I think this is ready to merge. I incorporated your suggestions, then ran the checks locally and all passed.

Copy link
Owner

@inducer inducer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is almost good. Just one more thing as far as I can tell.

@inducer inducer enabled auto-merge (squash) August 26, 2022 20:49
@inducer
Copy link
Owner

inducer commented Aug 26, 2022

LGTM, thanks!

@inducer inducer merged commit 1afbf4b into inducer:main Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants