Conversation
9d54209 to
5c07e4d
Compare
Owner
|
Hmm, odd coinidence. Take a look at #44, which seems to pursue goals relatively similar goals to this PR (IIUC that is). Could the two of you come up with a joint proposal so that we can pursue that? Thanks in advance! |
a748ec8 to
1e1019b
Compare
Contributor
Author
|
@inducer, I think this is ready to merge. I incorporated your suggestions, then ran the checks locally and all passed. |
inducer
reviewed
Aug 26, 2022
Owner
inducer
left a comment
There was a problem hiding this comment.
Thanks! This is almost good. Just one more thing as far as I can tell.
Owner
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm also interested in the feature outlined in this issue. I've put together a starting point for the associated wrapper.
Some features which may be missing are:
Happy to discuss any suggestions.