Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a subprocess-based timeout mechanism to prevent long-running SymPy-based text answer matching from hanging, and wires it into the text question matchers.
Changes:
- Introduce
call_with_timeout()(multiprocessing-based) and aTIMED_OUTsentinel inrelate.utils. - Update SymPy-based matchers in
course/page/text.pyto evaluate/compare expressions under a time limit and provide timeout feedback. - Add unit tests for
call_with_timeoutand update basedpyright configuration/baseline to supportSentinel.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
relate/utils.py |
Adds call_with_timeout() and TIMED_OUT sentinel used to bound execution time in subprocesses. |
course/page/text.py |
Uses the timeout helper to protect SymPy evaluation in SymbolicExpressionMatcher and FloatMatcher. |
tests/test_relate_utils.py |
Adds unit tests validating success/timeout/exception behavior for call_with_timeout(). |
pyproject.toml |
Enables basedpyright experimental features needed for Sentinel typing. |
.basedpyright/baseline.json |
Updates static-type baseline to account for the new code/tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
inducer
force-pushed
the
textmatcher-timeouts
branch
3 times, most recently
from
a8a223a to
a15dbde
Compare
inducer
force-pushed
the
textmatcher-timeouts
branch
from
a15dbde to
78211a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.