Skip to content

Changing login function to use latest URL used by the shine app#29

Merged
indykoning merged 1 commit intoindykoning:masterfrom
muppet3000:bugfix/fixing-login-url
Jun 15, 2022
Merged

Changing login function to use latest URL used by the shine app#29
indykoning merged 1 commit intoindykoning:masterfrom
muppet3000:bugfix/fixing-login-url

Conversation

@muppet3000
Copy link
Contributor

Fixes #28

@Lrss Lrss mentioned this pull request Jun 14, 2022
Copy link
Contributor

@TheWalrus2 TheWalrus2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can confirm this works

Copy link

@JasperPlant JasperPlant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this change in my local testing environment and can confirm that this fixes the login issue.

Copy link

@jarekgrzabel jarekgrzabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@indykoning
Copy link
Owner

Thank you! 🚀 will take a look at at it soon and get it released

@muppet3000
Copy link
Contributor Author

Thanks @indykoning as soon as it's released I'll do the change for HomeAssistant as well.

@indykoning indykoning merged commit 0dce365 into indykoning:master Jun 15, 2022
@indykoning
Copy link
Owner

The fix is available in version 1.2.2 🎉

@fpotjens
Copy link

I'm still confused... was there a new (patch) release of Home Assistant? I did not receive any update and I'm using HA on RPI so not able to (easy) fix the new url....
Can someone update me on the progress when I can expect the release?

@muppet3000
Copy link
Contributor Author

I'm still confused... was there a new (patch) release of Home Assistant? I did not receive any update and I'm using HA on RPI so not able to (easy) fix the new url.... Can someone update me on the progress when I can expect the release?

It will be in the next release of HomeAssistant: https://github.com/home-assistant/core/milestone/509

@fpotjens
Copy link

I'm still confused... was there a new (patch) release of Home Assistant? I did not receive any update and I'm using HA on RPI so not able to (easy) fix the new url.... Can someone update me on the progress when I can expect the release?

It will be in the next release of HomeAssistant: https://github.com/home-assistant/core/milestone/509

Ok thanks, So we are waiting on a fix of that open issue.....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Login error

6 participants