fix(channels): Propagate agent errors to channel users#479
Merged
Conversation
When the channels-manager subprocess for `infer agent` fails (e.g. LLM 400 on full context, gateway down), the error was logged on the daemon host but never delivered to the user, leaving them waiting in silence. Add a new `AgentErrorMessage` IPC type that the agent emits on stdout via a named-return defer in `RunAgentCommand` (covering all error returns plus panics). The channel manager forwards these as `❌ Error: …` messages and includes a stderr-tail safety net `❌ Agent failed: …` for crashes that exit before they can emit. Closes #478
Contributor
|
🎉 This PR is included in version 0.106.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
infer agentsubprocess (spawned byinfer channels-manager) failed - LLM 400 context-full, gateway down, panics - the failure was logged on the daemon host but never delivered to the channel user, who just waited in silence.AgentErrorMessageIPC type emitted on stdout via a named-returndefer(withrecover) inRunAgentCommand, so every error path is covered with no scattered changes.❌ Error: …and adds a stderr-tail safety net (❌ Agent failed: …) for hard crashes that exit before emitting.