fix(agent): drop redundant Idle transition that errored on every run#726
Merged
Conversation
The event-driven agent's state machine is constructed in Idle and a fresh machine backs every run, yet EventDrivenAgent.Start() unconditionally called Transition(ctx, StateIdle). There is no Idle->Idle edge, so the call always failed with "invalid transition from Idle to Idle" and logged an error with a full stacktrace on every turn. It was harmless (the seeded MessageReceivedEvent drives the real Idle->CheckingQueue flow) but noisy once #722 cleared the unrelated keybinding log flood that had masked it. Delete the redundant transition; the loop already begins in Idle. Add a regression test asserting Start() issues no Idle-targeted transition. Closes #725
inference-gateway-releaser Bot
added a commit
that referenced
this pull request
Jul 3, 2026
## [0.128.0](v0.127.0...v0.128.0) (2026-07-03) ### 🚀 Features * **chat:** make status indicators selectable with /tools and /a2a views ([#732](#732)) ([6882de0](6882de0)), closes [#717](#717) [#717](#717) ### 🐛 Bug Fixes * **agent:** drop redundant Idle transition that errored on every run ([#726](#726)) ([469ec64](469ec64)), closes [#722](#722) [#725](#725) * **agent:** report session-cumulative total_turns in completion logs ([#728](#728)) ([0d8fb08](0d8fb08)), closes [#727](#727) * **a2a:** route active A2A reads and HasPending through the job supervisor ([#693](#693)) ([#721](#721)) ([dcd0670](dcd0670)), closes [#718](#718) [#719](#719) [#720](#720) * **keybindings:** stop "unknown keybinding action" log flood ([#724](#724)) ([c828426](c828426)), closes [#714](#714) [#722](#722) * **a2a:** unify background-job liveness, clear, and cancel on the supervisor contract ([#730](#730)) ([eb37fd0](eb37fd0)), closes [#693](#693) [#720](#720) [#718](#718) [#719](#719) * **logging:** use structured key/value form at misused call sites ([#729](#729)) ([cd96028](cd96028)), closes [#722](#722) [#724](#724) [#724](#724) [#723](#723) * **tools:** wait for pipe readers before reaping detached bash shells ([#716](#716)) ([e1d0d84](e1d0d84)), closes [#696](#696) ### ⚡ Performance Improvements * **tui:** cache per-entry rendering and keep the Update loop responsive ([#731](#731)) ([8c9db0d](8c9db0d)) ### 📚 Documentation * **a2a:** add SKILL.md documentation for Agent2Agent protocol ([defcd57](defcd57)) ### 🔧 Build System * **deps:** bump golang.org/x/net from 0.47.0 to 0.55.0 in /examples/mcp/mcp-server ([#715](#715)) ([990803b](990803b)) ### 🧹 Maintenance * **flox:** bump dev deps ([d0c8f6b](d0c8f6b))
Contributor
|
🎉 This PR is included in version 0.128.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EventDrivenAgent.Start()unconditionally calledTransition(ctx, StateIdle), but the state machine is constructed inIdleand there is noIdle -> Idleedge — so the call failed on every run withinvalid transition from Idle to Idleand logged an error + full stacktrace on every turn. It was harmless (the seededMessageReceivedEventdrives the realIdle -> CheckingQueueflow) but became visible noise once #722 cleared the keybinding log flood that had masked it.Fix
Delete the redundant transition — the loop already begins in
Idle. Zero state-machine semantic change: the call never succeeded, so nothing that passed can break.Test
TestStart_DoesNotRedundantlyTransitionToIdleassertsStart()issues noIdle-targeted transition (the first transition must beIdle -> CheckingQueuefrom the seeded event). Confirmed it fails if the removed line is restored.go test ./...,task lint(0 issues), andtask buildall pass.Closes #725