Skip to content

Release 0.5.1#38

Merged
Shaumik-Ashraf merged 8 commits intomainfrom
release-0.5.1
Mar 11, 2025
Merged

Release 0.5.1#38
Shaumik-Ashraf merged 8 commits intomainfrom
release-0.5.1

Conversation

@Shaumik-Ashraf
Copy link
Copy Markdown
Contributor

@Shaumik-Ashraf Shaumik-Ashraf commented Mar 10, 2025

Summary

  • Add data/igs/.keep to git so it conforms to new platform deployable rspec
  • update to v0.5.1

Testing Guidance

  1. Checkout branch
  2. bundle exec rake

@Shaumik-Ashraf Shaumik-Ashraf self-assigned this Mar 10, 2025
@dehall
Copy link
Copy Markdown
Contributor

dehall commented Mar 10, 2025

I don't think anything permanent is supposed to go in the data directory. The new inferno-core release will copy the IG TGZ files there at startup, and potentially clear it out beforehand. So the docker-compose change is needed but the rest of the changes pointing to the data dir should probably be reverted

Copy link
Copy Markdown
Contributor

@dehall dehall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing, running the test kit now results in data/igs/ipa_v100.tgz as an untracked file in git. Can you also add this line in gitignore: https://github.com/inferno-framework/inferno-core/blob/a81794d0c9d85e00036430d24a77d5b9c2da2b9b/.gitignore#L2

Unfortunately we might have to do this across a bunch of test kits if we haven't already

end
```

## 3. Inferno Validator UI
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why this is being removed. You should just update the commented out ig volume line for the old validator service as well.

@Shaumik-Ashraf Shaumik-Ashraf merged commit ad3b9ff into main Mar 11, 2025
1 check passed
@Shaumik-Ashraf Shaumik-Ashraf deleted the release-0.5.1 branch March 11, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants