Skip to content

FI-3813: migrate to core Must Support assertion#39

Merged
dehall merged 1 commit intomainfrom
fi-3813-ms-assertion
Mar 20, 2025
Merged

FI-3813: migrate to core Must Support assertion#39
dehall merged 1 commit intomainfrom
fi-3813-ms-assertion

Conversation

@dehall
Copy link
Copy Markdown
Contributor

@dehall dehall commented Mar 19, 2025

Summary

This PR migrates the MustSupportTest and MustSupportMetadataExtractor to leverage versions that are now included in core. This is not a "complete" migration, but aims for "minimal but clean".

  • MustSupportMetadataExtractor: This class now extends the version from inferno_core. Ripped out most of the innards of this class except for handle_special_cases and must_supports which calls super then handle_special_cases
    • There are some slight differences in the resulting extracted metadata because the version in core was based off the US Core test kit version, which continued to evolve after this version was cloned from it.
    • Only one other change had to be made to handle these differences: slices have "slice_id" not "name"
  • MustSupportTest: Ripped out most of the innards of this class except for handle_special_cases which calls the core assertion assert_must_support_elements_present
  • Re-generated metadata based on these changes

Testing Guidance

Running all MS tests (really all tests in general) should produce identical results to what's currently on prod. It's possible there could be some slight variations in how missing field names are reported but I didn't see instances of that in my testing. Unless something is clearly different and wrong, I think we should consider it ok for the field names to be reported slightly differently going forward.

@dehall dehall requested a review from Shaumik-Ashraf March 19, 2025 17:01
Copy link
Copy Markdown
Contributor

@Shaumik-Ashraf Shaumik-Ashraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this branch and production behave the same

@dehall dehall merged commit d20168a into main Mar 20, 2025
1 check passed
@dehall dehall deleted the fi-3813-ms-assertion branch March 20, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants