output urls for interacting with waits for scripting#39
Merged
Conversation
* Simulation flag added to tests (#40) * Added simulation verification flag to tests * Rubocop patch * Rubocop spec patch * Updated gemfile to use new inferno_core gem * Ensure newest inferno_core version * Add execution test scripts for R4 client and server suites * Add execution scripts for R4 client and server suites * server and client yaml execution script files * YAML files for server and client execution scripts * YAML files for server and client combined execution scripts * address comments, Add github workflow, gitignore, and rakefile * Rename subscriptions_r4_empty_client_expected.json to subscriptions_r4_empty_with_commands_client_expected.json * Rename subscriptions_r4_empty_server_expected.json to subscriptions_r4_empty_with_commands_server_expected.json * Rename subscriptions_r4_full_resource_client_expected.json to subscriptions_r4_full_resource_with_commands_client_expected.json * Rename subscriptions_r4_full_resource_server_expected.json to subscriptions_r4_full_resource_with_commands_server_expected.json * Apply suggestion from @karlnaden Co-authored-by: Karl Naden <86612928+karlnaden@users.noreply.github.com> * Update .gitignore following inferno-core template (*.manifest) * Update .gitignore * Update .gitignore * use actual inferno-core gem * fix capability statement on inferno-qa * Update execution_scripts/advance_wait.rb Co-authored-by: Karl Naden <86612928+karlnaden@users.noreply.github.com> * Apply suggestion from @karlnaden Co-authored-by: Karl Naden <86612928+karlnaden@users.noreply.github.com> * Apply suggestion from @karlnaden Co-authored-by: Karl Naden <86612928+karlnaden@users.noreply.github.com> * Apply suggestion from @karlnaden Co-authored-by: Karl Naden <86612928+karlnaden@users.noreply.github.com> * Apply suggestion from @karlnaden Co-authored-by: Karl Naden <86612928+karlnaden@users.noreply.github.com> * Apply suggestion from @karlnaden Co-authored-by: Karl Naden <86612928+karlnaden@users.noreply.github.com> * Apply suggestion from @karlnaden Co-authored-by: Karl Naden <86612928+karlnaden@users.noreply.github.com> * Apply suggestion from @karlnaden Co-authored-by: Karl Naden <86612928+karlnaden@users.noreply.github.com> * Update subscriptions_test_kit.gemspec * Update Gemfile.lock faraday added as a dependency of subscriptions_test_kit * Update subscriptions_test_kit.gemspec * Make advance_wait.rb executable * Accidentally deleted expected json files on last commit, re-commited them here. Advance_wait.rb should also be executable for all users now * Updated to inferno 1.2.1 * Execution scripts README changes --------- Co-authored-by: Lucas Tucker <128156413+ljtucker@users.noreply.github.com> Co-authored-by: Karl Naden <86612928+karlnaden@users.noreply.github.com> Co-authored-by: Karl Naden <karl@glenviewassociates.com>
ljtucker
approved these changes
Apr 27, 2026
Contributor
ljtucker
left a comment
ljtucker
left a comment
There was a problem hiding this comment.
Code looks clean, and all tests passed as described in the EXECUTE_SCRIPTS md file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Non-functional change that supports execution scripts.
Testing Guidance
Run server against client tests and confirm they still run as expected (attestation and continuation links in wait dialogs still work)