FI-3010: Split out Subscription Rejection tests#7
Conversation
|
|
||
| subscription_field[field_name] = unsupported_info['field_value'] | ||
|
|
||
| send_unsupported_subscription(subscription, unsupported_info['unsupported_title'], |
There was a problem hiding this comment.
This logic does not appear to be doing the right thing. When I run it against the client tests, which echo the request back with a 201, it succeeds. Seems like that should be a failure because the cross version extension is still in the returned subscription and it succeeded.
There was a problem hiding this comment.
Addressed in 06d86cb. Made changes to this test to actually just fail when receiving a 201 since I don't think it makes sense to alter the values based on the requirement description ("cross version extensions SHOULD NOT be used on R4 subscriptions to describe any elements") from HL7 guide. I can change this though to be closer to what it was before, or remove the test if we don't think it's as fleshed out as it doesn't have a requirement.
There was a problem hiding this comment.
Not sure I agree with the changes. I think both approaches - allowing removal of the offending value are requiring rejection - are defensible. The IG also says that "servers MAY reject or coerce, according to their policies". Its in a different section, but it feels like it could easily apply here as well and that "coerce" could include removal of invalid extensions. If the verification code was working, I would prefer to leave it in rather than rip it out at this point. Interested to hear your reactions.
There was a problem hiding this comment.
nevermind - I guess the point was that this logic wasn't working, so I'm fine leaving it out!
|
to resolve the requirements-coverage CI failure, run the |
commit b2729a3 Merge: 0a35b40 6039a82 Author: Karl Naden <86612928+karlnaden@users.noreply.github.com> Date: Fri Jan 10 14:03:38 2025 -0500 Merge pull request #15 from inferno-framework/support-pas Client Test Notification Generation Enhancements commit 6039a82 Author: Karl Naden <knaden@mitre.org> Date: Tue Jan 7 12:53:15 2025 -0500 update error message to include content type commit 3567a96 Author: Karl Naden <knaden@mitre.org> Date: Tue Jan 7 12:53:00 2025 -0500 status request code is GET commit 0586882 Author: Karl Naden <knaden@mitre.org> Date: Tue Jan 7 12:15:40 2025 -0500 use tagged requests instead of inputs as the validation content source commit 96a85e2 Author: Karl Naden <knaden@mitre.org> Date: Tue Jan 7 11:40:30 2025 -0500 rename method add option to find_subscription as json commit 88287b6 Author: Karl Naden <knaden@mitre.org> Date: Mon Jan 6 12:26:47 2025 -0500 fix filter criteria format in example subscriptions commit 7e97606 Author: Karl Naden <knaden@mitre.org> Date: Mon Jan 6 11:36:10 2025 -0500 remove checks on resource types in focus elements and note it as a limitation commit 289acfb Author: Karl Naden <knaden@mitre.org> Date: Mon Jan 6 10:24:03 2025 -0500 allow notification references to use urn / uuids commit 1c8d587 Author: Karl Naden <knaden@mitre.org> Date: Fri Jan 3 12:15:38 2025 -0500 update event-notification timestamps commit 6997ce3 Author: Karl Naden <knaden@mitre.org> Date: Thu Jan 2 23:30:39 2025 -0500 update subscription topic in status entry commit b13a33a Author: Karl Naden <knaden@mitre.org> Date: Thu Jan 2 23:05:25 2025 -0500 set subscription status entry.response.status commit d68f4a3 Author: Karl Naden <knaden@mitre.org> Date: Thu Jan 2 10:52:48 2025 -0500 update timestamp, remove extra entries from handshake commit 0a35b40 Merge: 20b3695 f8e025a Author: Karl Naden <86612928+karlnaden@users.noreply.github.com> Date: Mon Dec 30 13:10:19 2024 -0500 Merge pull request #14 from inferno-framework/header-bug Correctly add authorization header to Subscription.channel.header commit f8e025a Author: Karl Naden <86612928+karlnaden@users.noreply.github.com> Date: Mon Dec 30 10:35:30 2024 -0500 condition fix Co-authored-by: Tom Strassner <tstrassner@mitre.org> commit f578c0e Author: Karl Naden <knaden@mitre.org> Date: Fri Dec 20 16:29:13 2024 -0500 fix bug when adding header to the subscription commit 20b3695 Author: Tom Strassner <tstrassner@mitre.org> Date: Thu Nov 7 08:09:29 2024 -0600 Release 0.9.3 (#11) * Bump version * Add changelog * Downgrade release to patch, version to 0.9.3 commit b7dccba Merge: 19ae2a9 33f8527 Author: Karl Naden <86612928+karlnaden@users.noreply.github.com> Date: Wed Nov 6 11:34:44 2024 -0500 Merge pull request #6 from inferno-framework/description-fix Updated typo in text commit 19ae2a9 Author: Stephen MacVicar <Jammjammjamm@users.noreply.github.com> Date: Wed Nov 6 10:58:59 2024 -0500 FI-3410: Update inferno core requirement (#9) * update inferno core requirement * update dependencies commit 33f8527 Author: NCADY <ncady@mitre.org> Date: Mon Oct 28 13:09:00 2024 -0400 Updated typo in text
2 participants
Summary
Testing Guidance