Skip to content

Conversation

@isthaison
Copy link
Contributor

What problem does this PR solve?

allow remember  on local localStorage web client

Type of change

  • Refactoring

allow remember  on local localStorage web client
@KevinHuSh KevinHuSh changed the title allow remember on local localStorage web client Fix: allow remember on local localStorage web client Mar 21, 2025
@KevinHuSh KevinHuSh requested a review from cike8899 March 21, 2025 08:38
@isthaison isthaison closed this Mar 21, 2025
@isthaison isthaison deleted the patch-2 branch March 21, 2025 09:48
@isthaison isthaison restored the patch-2 branch March 21, 2025 09:50
@isthaison isthaison reopened this Mar 21, 2025
@cike8899
Copy link
Contributor

This method is not safe. When someone else uses the browser of this machine, they can see the password of the previous person.

@isthaison
Copy link
Contributor Author

In terms of security, I think you can use the browser's password manager settings (Use the autocomplete property of the input to enable this feature). This will comply with the rules of being managed by the operating system account. but in the end, if someone has unauthorized access to the operating system, everything will be lost.

@isthaison
Copy link
Contributor Author

I will close it. Thank you.

@isthaison isthaison closed this Mar 24, 2025
@isthaison isthaison deleted the patch-2 branch March 27, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants