Merged
Conversation
Languages, Teams, DotNet versions
cliftonc
reviewed
Feb 29, 2024
|
|
||
| const getDotNetVersions = async (repo, keyword) => { | ||
| try { | ||
| const { data } = await octokit.request('GET https://api.github.com/search/code?q={keyword}+repo:{repo}', { |
Contributor
There was a problem hiding this comment.
Is there a reason we need to search vs know where this file is always located?
Contributor
Author
There was a problem hiding this comment.
Looking into that part (therefor I set the PR as Draft) - when Googling how to get all the csproj files in a GitHub repo the first answers are with search, but I think I have a way of using the Tree API and then get the content for the csproj files.
C# version is now done via csproj file content instead of searching Links seemed to be overlooked due to capitalisation of the name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Languages, Teams, DotNet versions