-
Notifications
You must be signed in to change notification settings - Fork 4
Support cutting planes technique. #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…eplace_variables_in_constraint() testcase hack.
deleting prior to merge to main branch
VariableRef changed to AbstractVariableRef.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #125 +/- ##
=========================================
Coverage ? 99.56%
=========================================
Files ? 15
Lines ? 1615
Branches ? 0
=========================================
Hits ? 1608
Misses ? 7
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@pulsipher Ready for review 🙂 |
pulsipher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments below, I am not also sure why the patch coverage is detecting something with the constraints file.
Refactor variable creation and add copy_model_and_gdp_data function.
created more tests accordingly. addition of test to check that model instances do not affect each other.
pulsipher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty good, please add comments and address the comments below.
pulsipher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This PR adds the cutting planes reformulation technique. The method iteratively generates cutting planes using a separation problem and relaxed Big-M formulation before applying a final reformulation.