fix: devDependencies issue in CI with text recognition#251
Merged
coolsoftwaretyler merged 2 commits intomainfrom Dec 16, 2025
Merged
fix: devDependencies issue in CI with text recognition#251coolsoftwaretyler merged 2 commits intomainfrom
coolsoftwaretyler merged 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: e98bf92 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
|
Huh yeah I think the example project's dependencies get bumped? Maybe we need to tack onto that step and look for deps/dev deps in the modules themselves on publish |
frankcalise
approved these changes
Dec 16, 2025
frankcalise
reviewed
Dec 16, 2025
| }, | ||
| "devDependencies": { | ||
| "@infinitered/react-native-mlkit-core": "3.1.0", | ||
| "@infinitered/react-native-mlkit-core": "5.0.0", |
Collaborator
There was a problem hiding this comment.
do we need this one if it is a dependency? is it useful for typescript or redundant you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix this CI issue, although I'm curious why the original PR was green but main merge went red. Would be nice to have better protections against that.
Created a follow up issue to investigate: #250