Skip to content

Conversation

@silasjmatson
Copy link
Contributor

@silasjmatson silasjmatson commented Oct 7, 2025

Updates to get feature parity with existing reactotron and display measures in ms. #29

Screenshot 2025-10-07 at 11 33 17 AM Screenshot 2025-10-07 at 11 33 41 AM

Copy link
Collaborator

@joshuayoes joshuayoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Screen.Recording.2025-10-07.at.12.38.09.PM.mov

Manual Test Steps

reactotron-macos setup

  1. gh pr checkout 50
  2. npm install
  3. npm run pod
  4. npm run start
  5. npm run macos
  6. node -e "require('./standalone-server').startReactotronServer({ port: 9292 })"

reactotron example app setup

  1. yarn install
    Add Reactotron standalone server port to example app configuration
diff --git a/apps/example-app/app/devtools/ReactotronConfig.ts b/apps/example-app/app/devtools/ReactotronConfig.ts
index a5c7d5b6..9b9c1dad 100644
--- a/apps/example-app/app/devtools/ReactotronConfig.ts
+++ b/apps/example-app/app/devtools/ReactotronConfig.ts
@@ -18,6 +18,7 @@ import { Reactotron } from "./ReactotronClient"
 
 const reactotron = Reactotron.configure({
   name: require("../../package.json").name,
+  port: 9292,
   onConnect: () => {
     /** since this file gets hot reloaded, let's clear the past logs every time we connect */
     Reactotron.clear()
  1. yarn workspace example-app start
  2. Start on a different port to avoid conflicting with reactotron-macos
  3. Press i to launch in iOS simulator
  4. Consider Cmd + Shift + R to reload reactotron-macos to get connection
  5. Tap "Benchmarking" in iOS Simulator
  6. Click "Slow Benchmarks" in iOS Simulator
  7. See "BENCHMARK" timeline log in reactotron-macos

hermes-engine: b5c9cfbe6415f1b0b24759f2942c8f33e9af6347
IRNativeModules: 2fa316ab0ca91ec3e7bd4ba7ab2fc1f642fb5542
RCT-Folly: e8b53d8c0d2d9df4a6a8b0a368a1a91fc62a88cb
RCT-Folly: abec2d7f4af402b4957c44e86ceff8725b23c1b4
Copy link
Collaborator

@joshuayoes joshuayoes Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: if we get CI setup on here, we should probably figure out how to get these files locked down.

I will say that they were stable after I pulled it down.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I had to resolve a conflict with this file.

@silasjmatson silasjmatson merged commit df2bf73 into main Oct 7, 2025
4 checks passed
@silasjmatson silasjmatson deleted the performance-tab branch October 7, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants