-
Notifications
You must be signed in to change notification settings - Fork 0
Updates to benchmarking #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Updates display to have parity with existing reactotron * Update timeline benchmark to display in ms rather than seconds
joshuayoes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Screen.Recording.2025-10-07.at.12.38.09.PM.mov
Manual Test Steps
reactotron-macos setup
gh pr checkout 50npm installnpm run podnpm run startnpm run macosnode -e "require('./standalone-server').startReactotronServer({ port: 9292 })"
reactotron example app setup
yarn install
Add Reactotron standalone server port to example app configuration
diff --git a/apps/example-app/app/devtools/ReactotronConfig.ts b/apps/example-app/app/devtools/ReactotronConfig.ts
index a5c7d5b6..9b9c1dad 100644
--- a/apps/example-app/app/devtools/ReactotronConfig.ts
+++ b/apps/example-app/app/devtools/ReactotronConfig.ts
@@ -18,6 +18,7 @@ import { Reactotron } from "./ReactotronClient"
const reactotron = Reactotron.configure({
name: require("../../package.json").name,
+ port: 9292,
onConnect: () => {
/** since this file gets hot reloaded, let's clear the past logs every time we connect */
Reactotron.clear()
yarn workspace example-app start- Start on a different port to avoid conflicting with reactotron-macos
- Press
ito launch in iOS simulator - Consider
Cmd + Shift + Rto reload reactotron-macos to get connection - Tap "Benchmarking" in iOS Simulator
- Click "Slow Benchmarks" in iOS Simulator
- See "BENCHMARK" timeline log in reactotron-macos
| hermes-engine: b5c9cfbe6415f1b0b24759f2942c8f33e9af6347 | ||
| IRNativeModules: 2fa316ab0ca91ec3e7bd4ba7ab2fc1f642fb5542 | ||
| RCT-Folly: e8b53d8c0d2d9df4a6a8b0a368a1a91fc62a88cb | ||
| RCT-Folly: abec2d7f4af402b4957c44e86ceff8725b23c1b4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: if we get CI setup on here, we should probably figure out how to get these files locked down.
I will say that they were stable after I pulled it down.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I had to resolve a conflict with this file.
Updates to get feature parity with existing reactotron and display measures in ms. #29