A test run at breaking async storage out of what is normally shipped.#16
Conversation
jamonholmgren
left a comment
There was a problem hiding this comment.
Is there somewhere you can document the new API?
|
Yeah, right now the documentation for all things reactotron live on the main repo. If I am going to merge this there would have to be a matching PR on that repo to document this change. I have been going back and forth on pushing the documentation that is specific to each reactotron repo to the repo itself. I am open to suggestion on that front as well. |
|
I am okay with it living on the main repo! |
|
I've changed directions on this a little bit so that we are not so dependent on specific implementations. This now works with anything that has a |
|
I like the sethandler approach a lot better than the original, so +1 from the peanut gallery. |
|
@djMax I hardly call a consumer of this library the peanut gallery. Thanks for your input! I am thinking that is the direction this is going to go. It will have to be a breaking change so I will need to update some docs and make sure to get this called out when I go to merge this. I will have this all wrapped up before .60 lands in stable 👍 |
|
Hi everyone. I'm trying to use with @react-native-community/async-storage but not working. I use "reactotron-react-native": "3.6.2". How I can use it? Thanks. |
|
I need to get this merged then you should be good to go. I will try and work on that this weekend |
|
Any update for this issue? |
|
@rmevans9 Let me know if you need any help on this. would be amazing having this out asap. Apparently there's a bunch of people complaining about it. |
|
I will be releasing this as a beta version tonight. |
|
🎉 This PR is included in version 4.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This would be a breaking change because it introduces these two things:
useReactNativeno longer takes the configuration for async storage and doesn't turn it on at allThe changes a user would have to do it their config are: