New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly work with the gradient layer if exists #199

Merged
merged 1 commit into from Feb 26, 2015

Conversation

Projects
None yet
3 participants
@squidpunch
Contributor

squidpunch commented Feb 24, 2015

this should fix the gradient issues reported in #198

Note: I didnt update the rest of the view issues we were seeing @twerth @GantMan

@squidpunch

This comment has been minimized.

Show comment
Hide comment
@squidpunch

squidpunch Feb 25, 2015

Contributor

hey @GantMan @twerth can you give this a look? I realize that without this fix, when rotating the device we are adding layer after layer to the view... 😮

Contributor

squidpunch commented Feb 25, 2015

hey @GantMan @twerth can you give this a look? I realize that without this fix, when rotating the device we are adding layer after layer to the view... 😮

@GantMan

This comment has been minimized.

Show comment
Hide comment
@GantMan

GantMan Feb 26, 2015

Member

gradient works great! What do you propose we do for positioning this on rotation?

Member

GantMan commented Feb 26, 2015

gradient works great! What do you propose we do for positioning this on rotation?

@twerth

This comment has been minimized.

Show comment
Hide comment
@twerth

twerth Feb 26, 2015

Member

Just move it somewhere, or we can relay out that whole thing. Or frankly, you can just leave it, it's not a big deal

Member

twerth commented Feb 26, 2015

Just move it somewhere, or we can relay out that whole thing. Or frankly, you can just leave it, it's not a big deal

@GantMan

This comment has been minimized.

Show comment
Hide comment
@GantMan

GantMan Feb 26, 2015

Member

Yeah, either way it shouldn't hold up this PR. Good fix Squid.

Member

GantMan commented Feb 26, 2015

Yeah, either way it shouldn't hold up this PR. Good fix Squid.

twerth added a commit that referenced this pull request Feb 26, 2015

Merge pull request #199 from squidpunch/fix-gradient
Properly work with the gradient layer if exists

@twerth twerth merged commit 05b1adb into infinitered:master Feb 26, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment