New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/delay #207

Merged
merged 5 commits into from Mar 11, 2015

Conversation

Projects
None yet
4 participants
@jamonholmgren
Member

jamonholmgren commented Mar 5, 2015

Adds app.after(/delay) and app.every.

rmq.app.after 3 do
  puts "Time waits for no one"
end

rmq.app.every 0.1 do
  puts "Jamon is cool"
end
@GantMan

This comment has been minimized.

Show comment
Hide comment
@GantMan

GantMan Mar 5, 2015

Member

LOVE IT, but tests failed.

Member

GantMan commented Mar 5, 2015

LOVE IT, but tests failed.

@jamonholmgren

This comment has been minimized.

Show comment
Hide comment
@jamonholmgren
Member

jamonholmgren commented Mar 6, 2015

screen shot 2015-03-05 at 5 01 41 pm

@jamonholmgren

This comment has been minimized.

Show comment
Hide comment
@jamonholmgren

jamonholmgren Mar 6, 2015

Member

My theory is that before / after conflicted with the before/after hooks in MacBacon. @GantMan

Member

jamonholmgren commented on spec/app.rb in bea6481 Mar 6, 2015

My theory is that before / after conflicted with the before/after hooks in MacBacon. @GantMan

This comment has been minimized.

Show comment
Hide comment
@GantMan

GantMan Mar 6, 2015

Member

makes sense!

Member

GantMan replied Mar 6, 2015

makes sense!

@GantMan

This comment has been minimized.

Show comment
Hide comment
@GantMan

GantMan Mar 6, 2015

Member

@jamonholmgren it looks like the comparison of 0.011084.<(0.011) is causing some kind of error on this machine... Maybe a little more leeway?

Member

GantMan commented Mar 6, 2015

@jamonholmgren it looks like the comparison of 0.011084.<(0.011) is causing some kind of error on this machine... Maybe a little more leeway?

Show outdated Hide outdated spec/app.rb
timer = @app.every 0.01 do
after_time = Time.now
(after_time - before_time).should.be > 0.009
(after_time - before_time).should.be < 0.011

This comment has been minimized.

@markrickert

markrickert Mar 6, 2015

Member

.should.be.close 0.011, 0.01

@markrickert

markrickert Mar 6, 2015

Member

.should.be.close 0.011, 0.01

@GantMan

This comment has been minimized.

Show comment
Hide comment
@GantMan

GantMan Mar 11, 2015

Member

Does this issue need some assistance?

Member

GantMan commented Mar 11, 2015

Does this issue need some assistance?

@twerth

This comment has been minimized.

Show comment
Hide comment
@twerth

twerth Mar 11, 2015

Member

Gant would you check this and merge it if it passes

Member

twerth commented Mar 11, 2015

Gant would you check this and merge it if it passes

@GantMan

This comment has been minimized.

Show comment
Hide comment
@GantMan

GantMan Mar 11, 2015

Member

Yeah, I'll try to investigate the test. Even if it's a great feature we might need to mute the test a bit if it causes master to fail tests. I'll check into it.

Member

GantMan commented Mar 11, 2015

Yeah, I'll try to investigate the test. Even if it's a great feature we might need to mute the test a bit if it causes master to fail tests. I'll check into it.

@jamonholmgren

This comment has been minimized.

Show comment
Hide comment
@jamonholmgren

jamonholmgren Mar 11, 2015

Member

@GantMan I just totally ignored you after you told me what was going on. Fixed now.

Member

jamonholmgren commented Mar 11, 2015

@GantMan I just totally ignored you after you told me what was going on. Fixed now.

@GantMan

This comment has been minimized.

Show comment
Hide comment
@GantMan

GantMan Mar 11, 2015

Member

@jamonholmgren that's ok, I think that means we're in a relationship now.

Member

GantMan commented Mar 11, 2015

@jamonholmgren that's ok, I think that means we're in a relationship now.

twerth added a commit that referenced this pull request Mar 11, 2015

@twerth twerth merged commit db51661 into infinitered:master Mar 11, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@jamonholmgren

This comment has been minimized.

Show comment
Hide comment
@jamonholmgren
Member

jamonholmgren commented Mar 11, 2015

crying

@GantMan

This comment has been minimized.

Show comment
Hide comment
@GantMan

GantMan Mar 13, 2015

Member

wait... was this ever fixed? I'm unable to run tests locally now, and this is crashing it.

Member

GantMan commented Mar 13, 2015

wait... was this ever fixed? I'm unable to run tests locally now, and this is crashing it.

@GantMan

This comment has been minimized.

Show comment
Hide comment
@GantMan

GantMan Mar 13, 2015

Member

Turns out it SOMETIMES fails :/

Might be worth adding another level of fuzziness. .009 instead of .01

Member

GantMan commented Mar 13, 2015

Turns out it SOMETIMES fails :/

Might be worth adding another level of fuzziness. .009 instead of .01

@jamonholmgren

This comment has been minimized.

Show comment
Hide comment
@jamonholmgren

jamonholmgren Mar 13, 2015

Member

@GantMan Yours is failing with 0.009 seconds? It should never go below 0.01... O_o

Member

jamonholmgren commented Mar 13, 2015

@GantMan Yours is failing with 0.009 seconds? It should never go below 0.01... O_o

@GantMan

This comment has been minimized.

Show comment
Hide comment
@GantMan

GantMan Mar 13, 2015

Member

I made a PR, and I linked to travis failing on 0.008! So I moved the test to 0.007. I know it sucks, but travis is crapping out on all my PRs today, bc of this.

Member

GantMan commented Mar 13, 2015

I made a PR, and I linked to travis failing on 0.008! So I moved the test to 0.007. I know it sucks, but travis is crapping out on all my PRs today, bc of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment