Skip to content

Feature/delay#207

Merged
twerth merged 5 commits into
infinitered:masterfrom
jamonholmgren:feature/delay
Mar 11, 2015
Merged

Feature/delay#207
twerth merged 5 commits into
infinitered:masterfrom
jamonholmgren:feature/delay

Conversation

@jamonholmgren
Copy link
Copy Markdown
Member

Adds app.after(/delay) and app.every.

rmq.app.after 3 do
  puts "Time waits for no one"
end

rmq.app.every 0.1 do
  puts "Jamon is cool"
end

@GantMan
Copy link
Copy Markdown
Member

GantMan commented Mar 5, 2015

LOVE IT, but tests failed.

@jamonholmgren
Copy link
Copy Markdown
Member Author

screen shot 2015-03-05 at 5 01 41 pm

@GantMan
Copy link
Copy Markdown
Member

GantMan commented Mar 6, 2015

@jamonholmgren it looks like the comparison of 0.011084.<(0.011) is causing some kind of error on this machine... Maybe a little more leeway?

Comment thread spec/app.rb Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.should.be.close 0.011, 0.01

@GantMan
Copy link
Copy Markdown
Member

GantMan commented Mar 11, 2015

Does this issue need some assistance?

@twerth
Copy link
Copy Markdown
Member

twerth commented Mar 11, 2015

Gant would you check this and merge it if it passes

@GantMan
Copy link
Copy Markdown
Member

GantMan commented Mar 11, 2015

Yeah, I'll try to investigate the test. Even if it's a great feature we might need to mute the test a bit if it causes master to fail tests. I'll check into it.

@jamonholmgren
Copy link
Copy Markdown
Member Author

@GantMan I just totally ignored you after you told me what was going on. Fixed now.

@GantMan
Copy link
Copy Markdown
Member

GantMan commented Mar 11, 2015

@jamonholmgren that's ok, I think that means we're in a relationship now.

twerth added a commit that referenced this pull request Mar 11, 2015
@twerth twerth merged commit db51661 into infinitered:master Mar 11, 2015
@jamonholmgren
Copy link
Copy Markdown
Member Author

crying

@GantMan
Copy link
Copy Markdown
Member

GantMan commented Mar 13, 2015

wait... was this ever fixed? I'm unable to run tests locally now, and this is crashing it.

@GantMan
Copy link
Copy Markdown
Member

GantMan commented Mar 13, 2015

Turns out it SOMETIMES fails :/

Might be worth adding another level of fuzziness. .009 instead of .01

@jamonholmgren
Copy link
Copy Markdown
Member Author

@GantMan Yours is failing with 0.009 seconds? It should never go below 0.01... O_o

@GantMan
Copy link
Copy Markdown
Member

GantMan commented Mar 13, 2015

I made a PR, and I linked to travis failing on 0.008! So I moved the test to 0.007. I know it sucks, but travis is crapping out on all my PRs today, bc of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants