GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds app.after(/delay) and app.every.
app.after(/delay) and app.every
rmq.app.after 3 do
puts "Time waits for no one"
rmq.app.every 0.1 do
puts "Jamon is cool"
Added rmq.app.after and rmq.app.every
Merge branch 'master' into feature/delay
LOVE IT, but tests failed.
Fix tests thanks @GantMan
My theory is that before / after conflicted with the before/after hooks in MacBacon. @GantMan
@jamonholmgren it looks like the comparison of 0.011084.<(0.011) is causing some kind of error on this machine... Maybe a little more leeway?
.should.be.close 0.011, 0.01
Does this issue need some assistance?
Gant would you check this and merge it if it passes
Merge branch 'master' of github.com:infinitered/rmq into feature/delay
Yeah, I'll try to investigate the test. Even if it's a great feature we might need to mute the test a bit if it causes master to fail tests. I'll check into it.
Fix timing on test
@GantMan I just totally ignored you after you told me what was going on. Fixed now.
@jamonholmgren that's ok, I think that means we're in a relationship now.
Merge pull request #207 from jamonholmgren/feature/delay
wait... was this ever fixed? I'm unable to run tests locally now, and this is crashing it.
Turns out it SOMETIMES fails :/
Might be worth adding another level of fuzziness. .009 instead of .01
@GantMan Yours is failing with 0.009 seconds? It should never go below 0.01... O_o
I made a PR, and I linked to travis failing on 0.008! So I moved the test to 0.007. I know it sucks, but travis is crapping out on all my PRs today, bc of this.