New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have travis test the iPhone 5 as well #218

Merged
merged 1 commit into from Mar 19, 2015

Conversation

Projects
None yet
3 participants
@squidpunch
Contributor

squidpunch commented Mar 16, 2015

We may want to expand this, but this adds the ability to test a
pointer issued that came up due to the different arch's so this is a
first pass at adding better coverage for these type of issues.

David Larrabee
Have travis test the iPhone 5 as well
  We may want to expand this, but this adds the ability to test a
  pointer issued that came up due to the different arch's so this is a
  first pass at adding better coverage for these type of issues.
@GantMan

This comment has been minimized.

Show comment
Hide comment
@GantMan

GantMan Mar 16, 2015

AWESOME! though I don't believe that works
Isn't it supposed to be? bundle exec rake spec device_name="iPhone 5"
That's what works on my local, not device_name=five

GantMan commented on 22bec56 Mar 16, 2015

AWESOME! though I don't believe that works
Isn't it supposed to be? bundle exec rake spec device_name="iPhone 5"
That's what works on my local, not device_name=five

This comment has been minimized.

Show comment
Hide comment
@squidpunch

squidpunch Mar 16, 2015

Owner

on line 11 I am creating a device, to make sure it exists (since this is travis we cant assume they have the same simulators etc....) so here I make a simulator and use that one i just built for the test run.

Owner

squidpunch replied Mar 16, 2015

on line 11 I am creating a device, to make sure it exists (since this is travis we cant assume they have the same simulators etc....) so here I make a simulator and use that one i just built for the test run.

This comment has been minimized.

Show comment
Hide comment
@GantMan

GantMan Mar 16, 2015

O cool! Look at your wizardry!

GantMan replied Mar 16, 2015

O cool! Look at your wizardry!

@markrickert

This comment has been minimized.

Show comment
Hide comment
@markrickert

markrickert Mar 19, 2015

Member

I like it!

Member

markrickert commented Mar 19, 2015

I like it!

markrickert added a commit that referenced this pull request Mar 19, 2015

@markrickert markrickert merged commit da13a34 into infinitered:master Mar 19, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment