Add ability for new iPhone sizes to resource_for_device and tests#235
Merged
Conversation
Member
|
@fvonhoven you accidentally added some images, would you remove those from the commit and update this PR please. |
Contributor
|
@twerth I think they were intentional, maybe for the 6 and 6 plus sizes? I dont have the sizes in front of me to confirm, but I think that was the intent. |
Member
|
yeah, seems those are needed for proper testing. |
Member
|
Yes, right, I'm sorry Frank, I'll merge now. |
twerth
added a commit
that referenced
this pull request
Apr 7, 2015
Add ability for new iPhone sizes to resource_for_device and tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And the corresponding Default images to the Resources folder for tests