New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability for new iPhone sizes to resource_for_device and tests #235

Merged
merged 2 commits into from Apr 7, 2015

Conversation

Projects
None yet
4 participants
@fvonhoven
Member

fvonhoven commented Apr 6, 2015

And the corresponding Default images to the Resources folder for tests

@twerth

This comment has been minimized.

Show comment
Hide comment
@twerth

twerth Apr 6, 2015

Member

@fvonhoven you accidentally added some images, would you remove those from the commit and update this PR please.

Member

twerth commented Apr 6, 2015

@fvonhoven you accidentally added some images, would you remove those from the commit and update this PR please.

@squidpunch

This comment has been minimized.

Show comment
Hide comment
@squidpunch

squidpunch Apr 6, 2015

Contributor

@twerth I think they were intentional, maybe for the 6 and 6 plus sizes? I dont have the sizes in front of me to confirm, but I think that was the intent.

Contributor

squidpunch commented Apr 6, 2015

@twerth I think they were intentional, maybe for the 6 and 6 plus sizes? I dont have the sizes in front of me to confirm, but I think that was the intent.

@GantMan

This comment has been minimized.

Show comment
Hide comment
@GantMan

GantMan Apr 6, 2015

Member

yeah, seems those are needed for proper testing.

Member

GantMan commented Apr 6, 2015

yeah, seems those are needed for proper testing.

@twerth

This comment has been minimized.

Show comment
Hide comment
@twerth

twerth Apr 7, 2015

Member

Yes, right, I'm sorry Frank, I'll merge now.

Member

twerth commented Apr 7, 2015

Yes, right, I'm sorry Frank, I'll merge now.

twerth added a commit that referenced this pull request Apr 7, 2015

Merge pull request #235 from fvonhoven/master
Add ability for new iPhone sizes to resource_for_device and tests

@twerth twerth merged commit 7c6e59a into infinitered:master Apr 7, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment