Don't stop looking for the view controller when it's a UINavigationController#237
Merged
Conversation
…ntroller I needed to put a UITablBarController inside a UINavigationController (I know, NOT recommended by Apple, but I had to do it nonetheless). This fixes the stylesheet not being able to be set because when it found a UINavigationController as the root_view_controller, it just gave up. I'm asking the method to keep searching till it gets an actual UIViewController and not blindly trust that the visibleViewController is a UIViewController.
twerth
added a commit
that referenced
this pull request
Apr 13, 2015
Don't stop looking for the view controller when it's a UINavigationController
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed to put a
UITabBarControllerinside aUINavigationController(I know, NOT recommended by Apple, but I had to do it nonetheless).This fixes the stylesheet not being able to be set because when it found a
UINavigationControlleras theroot_view_controller, it just gave up. I'm asking the method to keep searching till it gets an actualUIViewControllerand not blindly trust that thevisibleViewControlleris aUIViewController.An alternative so that we don't have to recurse one more time would be something like this: