Basic logic #1
Basic logic #1
Conversation
|
|
||
| // TODO: Should this be here? | ||
| // TODO: Invalidation? | ||
| export const withAuth = (Component: React.FC): React.FC => { |
There was a problem hiding this comment.
I don't think we should use HOC pattern now when we have hooks.
This could easily be an useAuth hook and the loading state is handled explicitly by the user of the hook. Doing it like this you have much more control of the UI, for example, you can use different skeleton animation on each page depending on the content type. It maybe seems like a lot of repetition, like you have to copy the same chunk of code to every page, but that is not a bad thing because you can do the abstraction elsewhere, like put everything into <PageLoader /> component abstraction that you repeat across the pages.
Here is an example:
https://github.com/vercel/next.js/blob/canary/examples/with-iron-session/pages/profile-sg.js#L5
https://github.com/vercel/next.js/blob/canary/examples/with-iron-session/pages/login.js#L8 - here hook handles redirects
There was a problem hiding this comment.
Also, I found HOCs hard to type when they pass some new props to the wrapped components.
|
This is one really old PR... I'll close this PR sorry |
Add coverage summary comparison
No description provided.