styling - chakra #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isBatak
suggested changes
Mar 23, 2021
| @@ -0,0 +1,16 @@ | |||
| export const Container = { | |||
| sizes: { | |||
| s: { | |||
There was a problem hiding this comment.
Chakra already has some global size settings for container theme.sizes.container https://chakra-ui.com/docs/layout/container
Author
There was a problem hiding this comment.
Yes but I wanted to create an example with custom size just to show how
There was a problem hiding this comment.
then at least use chakra size keywords xs, sm, md, lg,... https://chakra-ui.com/docs/theming/theme#sizes
| <Global styles={globalStyles} /> | ||
| <Component {...pageProps} /> | ||
| <ChakraProvider theme={theme}> | ||
| <Fonts /> |
There was a problem hiding this comment.
don't forget to preload fonts in _document
<Head>
<link
rel="preload"
href="/fonts/Space-Grotesk/SpaceGrotesk-Regular.woff"
as="font"
type="font/woff"
crossOrigin="true"
/>
</Head>
tsconfig.json
Outdated
| "jsx": "preserve", | ||
| "baseUrl": ".", | ||
| "paths": { | ||
| "@components/*": ["src/components/*"], |
There was a problem hiding this comment.
We haven't agreed on the syntax yet, but I would go with @/components/* and skip the shared and utilities
There was a problem hiding this comment.
isBatak
suggested changes
Mar 23, 2021
tsconfig.json
Outdated
| "jsx": "preserve", | ||
| "baseUrl": ".", | ||
| "paths": { | ||
| "@components/*": ["src/components/*"], |
There was a problem hiding this comment.
isBatak
approved these changes
Mar 24, 2021
|
|
||
| export const Fonts = () => ( | ||
| <Global | ||
| styles={` |
DarkoKukovec
approved these changes
Mar 25, 2021
Co-authored-by: Darko Kukovec <DarkoKukovec@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chakra
Add chakra to example project based on handbook rules.
Features:
https://infinum.com/handbook/books/frontend/react/css-in-js/chakra
https://infinum.com/handbook/books/frontend/react/project-structure#codecomponentscode-folder