Skip to content

Conversation

@alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Apr 24, 2019

Closes #11

Screen Shot 2019-04-24 at 1 20 24 PM

  • Refactor styles to use clockface variables
  • Ensure every overlay component has className prop
  • Ensure every overlay component has testID prop
  • Create OverlayMask component that can be customized via Gradients or InfluxColors
  • Add optional renderMaskElement prop to Overlay for customizing the mask directly (instead of prop drilling)
  • Write stories for individual overlay components
  • Add an Examples section for stories that feature all the overlay components together

Ensure all components have className and testID props
Update styles
Remove error handling decorators
Fix imports/exports
Copy link

@ebb-tide ebb-tide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent..

@alexpaxton alexpaxton merged commit 3840c1f into master Apr 24, 2019
@alexpaxton alexpaxton deleted the port-overlays branch April 24, 2019 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port over Overlays components

3 participants