-
Notifications
You must be signed in to change notification settings - Fork 321
fix(v2): http-write-timeout #5545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Fix the http-write-timeout definition, which should be similar to https://pkg.go.dev/net/http#Server.WriteTimeout - Add a Vale spelling config for v2 server options - Add influxdb to the test container packages (for testing service influxdb...) - Add Dockerfile config and test setup for testing some InfluxDB startup config options (using influxd)
| influxd --assets-path=/path/to/custom/assets-dir | ||
| ``` | ||
|
|
||
| <!--test-actual |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <!--test-actual | |
| <!--test:actual |
| Use the [`influx server-config` command](/influxdb/v2/reference/cli/influx/server-config/) | ||
| to retrieve your runtime server configuration. | ||
|
|
||
| <!--test: setup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <!--test: setup | |
| <!--test:setup |
|
@davidby-influx The substantive change fixes the http-write-timeout definition to be similar to https://pkg.go.dev/net/http#Server.WriteTimeout |
davidby-influx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
This change should be for 1.X, as well. |
In v1, is it |
|
On looking more closely, it is not present in 1.X, and the given equivalents do something different. In 2.X it is passed to the Go net/http package as a server setting; it 1.X those other two options are handled by Influx code and do slightly different things. So I was wrong it is in 1.x (we don't change the defaults for net/http Server write timeouts. Let's not put it in 1.X, and I'll look into the equivalency table in more depth later.... |
Closes #5513
Related testing and linting changes: