Skip to content

Replace default CI test products with Core and Telegraf#6812

Merged
jstirnaman merged 6 commits intoclaude/add-codeblock-ci-tests-jRvG9from
copilot/sub-pr-6810-again
Feb 11, 2026
Merged

Replace default CI test products with Core and Telegraf#6812
jstirnaman merged 6 commits intoclaude/add-codeblock-ci-tests-jRvG9from
copilot/sub-pr-6810-again

Conversation

Copy link
Contributor

Copilot AI commented Feb 11, 2026

Plan: Address review feedback

  • Add guard for empty PRODUCTS array after parsing
    • If all products are invalid and use_default_group is true, fall back to default group
    • If all products are invalid and use_default_group is false, fail with clear error message
  • Remove redundant output variable assignment before exit 1
  • Run code review and security checks
    • Code review passed
    • Security scan passed (0 issues)

Summary

Successfully addressed review feedback about handling invalid product inputs:

Changes Made (commits 3f0bd35, 801988b)

  1. Added validation guard after parsing the comma-separated products input

    • If all products are invalid and use_default_group=true: Falls back to default group (Core + Telegraf) with warning message
    • If all products are invalid and use_default_group=false: Fails workflow with clear error message (exit 1)
  2. Fixed inconsistency by removing redundant has-changes=false output before exit 1

The workflow now properly handles edge cases where users provide only unknown/unsupported product values, preventing silent failures with empty test matrices.

Validation

  • ✅ YAML syntax validated
  • ✅ Code review passed
  • ✅ Security scan passed (0 alerts)

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copy link
Contributor Author

Copilot AI commented Feb 11, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • repos.influxdata.com
    • Triggering command: /usr/lib/apt/methods/https /usr/lib/apt/methods/https --keep xo68heq03kpdnpuwtjp83lozb (dns block)
    • Triggering command: /usr/lib/apt/methods/https /usr/lib/apt/methods/https (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Update CI workflow for code-block testing per review feedback Replace default CI test products with Core and Telegraf Feb 11, 2026
Copilot AI requested a review from jstirnaman February 11, 2026 12:41
- Add support for all products: core, enterprise, v2, v1, telegraf,
  cloud, cloud-dedicated, cloud-serverless, clustered, explorer
- Define default test group (core + telegraf) when no product specified
- Exclude cloud products from automatic CI (manual dispatch only)
- Add placeholder scripts for products without pytest services
- Normalize product name handling (core, influxdb3_core, influxdb3-core)
- Log informative messages when excluded products' content changes
@jstirnaman jstirnaman force-pushed the copilot/sub-pr-6810-again branch from cf165bd to 61dc1fc Compare February 11, 2026 18:23
@jstirnaman jstirnaman marked this pull request as ready for review February 11, 2026 18:23
@jstirnaman jstirnaman requested a review from a team as a code owner February 11, 2026 18:23
@jstirnaman jstirnaman requested a review from Copilot February 11, 2026 18:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the docs CI code-block testing defaults to prioritize current products (InfluxDB 3 Core + Telegraf) instead of legacy defaults, and adds supporting test scripts for Core.

Changes:

  • Add test:codeblocks:influxdb3_core and a new test:codeblocks:default script in package.json.
  • Update .github/workflows/test.yml to support manual selection of products (comma-separated input) and default to a Core + Telegraf group when nothing is specified.
  • Adjust PR-change detection defaults so automatic CI runs focus on Core + Telegraf.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File Description
package.json Adds Core test script(s) and placeholder scripts for products without configured pytest services.
.github/workflows/test.yml Switches manual-dispatch inputs to product-based selection and changes default CI product selection toward Core + Telegraf.

jstirnaman and others added 3 commits February 11, 2026 13:11
- Remove pull_request trigger, keep only workflow_dispatch
- Change all exit codes to 0 so workflow never blocks PRs
- Use warnings instead of errors for failed tests
- Simplify job from detect-changes to parse-inputs
…ution

- PRs now trigger detection-only mode that suggests which products to test
- Actual test execution only runs via manual workflow_dispatch
- Add detect-test-products.js script using existing content-utils library
- Properly resolve shared content to affected product pages
- Non-blocking: PRs won't fail due to codeblock test issues
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI and others added 2 commits February 11, 2026 23:02
Co-authored-by: jstirnaman <212227+jstirnaman@users.noreply.github.com>
Co-authored-by: jstirnaman <212227+jstirnaman@users.noreply.github.com>
Copilot AI requested a review from jstirnaman February 11, 2026 23:04
@jstirnaman jstirnaman merged commit 83db31c into claude/add-codeblock-ci-tests-jRvG9 Feb 11, 2026
1 check was pending
@jstirnaman jstirnaman deleted the copilot/sub-pr-6810-again branch February 11, 2026 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants