fix(influxdb-v1): address review issues in InfluxQL spec pages#6931
Merged
jstirnaman merged 4 commits intojts-fix-rp-limit-clausesfrom Mar 12, 2026
Merged
Conversation
- Fix Enterprise KILL QUERY: restore proper EBNF grammar with optional ON clause and include both local and cluster examples - Fix duplicate "Durations" heading in both spec files - Fix list item spacing in Enterprise spec - Revert OSS heading level changes to maintain consistency with Enterprise - Restore Comments section to original location under Other in OSS spec
github-actions
bot
added
product:v1
Contributor
|
Contributor
Preview Pages for Review2 page(s) changed in this PR: @github-copilot please review the preview pages listed above using the template below: Visual Review PromptReview the rendered documentation pages at the preview URLs listed below. ChecklistFor each preview URL, verify:
OutputFollow the shared review comment format, severity definitions, and label Adapt the "Files Reviewed" section to list preview URLs instead of file Preview URLs |
Match Enterprise spec structure: Comments is a top-level section before Other, not nested inside it.
…ections Use text-typed code block for syntax notation and Syntax heading. Keep both local and cluster examples in sql-typed block.
jstirnaman
added a commit
that referenced
this pull request
Mar 12, 2026
…d add to ALTER RETENTION POLICY (#6591) * fix(influxdb-v1): correct FUTURE LIMIT and PAST LIMIT clause order and add to ALTER RETENTION POLICY - Fix clause order: FUTURE LIMIT must appear before PAST LIMIT (parser requirement) - Add FUTURE LIMIT and PAST LIMIT clauses to ALTER RETENTION POLICY syntax - Add grammar definitions for retention_future_limit and retention_past_limit - Add explicit note clarifying the required clause order - Fix "There are" style issue in spec.md closes #6590 * style(influxdb-v1): clean up InfluxQL spec formatting influxdb/v1: - Simplify introduction and use relative anchor links - Convert notes to GitHub-style callout syntax - Fix heading hierarchy (Letters/digits, Identifiers, Keywords, Literals as h3) - Standardize Duration units table heading - Fix "keywords" typo - Reword "See FAQ" to "For more information, see" - Simplify KILL QUERY section - Fix SHOW MEASUREMENT CARDINALITY heading level - Replace "There are" with active voice enterprise_influxdb/v1: - Add related links to frontmatter - Simplify introduction and use relative anchor links - Convert notes to GitHub-style callout syntax - Add Characters and Letters/digits to TOC - Standardize Duration units table heading - Fix "keywords" typo - Reword "See FAQ" to "For more information, see" - Simplify KILL QUERY section for Enterprise clusters - Update SHOW TAG KEYS grammar to include with_key_clause - Remove backticks from SHOW STATS headings * fix(influxdb-v1): address review issues in InfluxQL spec pages (#6931) * fix(influxdb-v1): address review issues in InfluxQL spec pages - Fix Enterprise KILL QUERY: restore proper EBNF grammar with optional ON clause and include both local and cluster examples - Fix duplicate "Durations" heading in both spec files - Fix list item spacing in Enterprise spec - Revert OSS heading level changes to maintain consistency with Enterprise - Restore Comments section to original location under Other in OSS spec * fix(influxdb-v1): move Comments section outside Other in OSS spec Match Enterprise spec structure: Comments is a top-level section before Other, not nested inside it. * fix(influxdb-v1): restore Comments link in OSS spec TOC * fix(influxdb-v1): rewrite KILL QUERY with clear Syntax and Examples sections Use text-typed code block for syntax notation and Syntax heading. Keep both local and cluster examples in sql-typed block.
jstirnaman
added a commit
that referenced
this pull request
Mar 13, 2026
* feat: [meta] https-insecure-certificate configuration (#6850) Add documentation for meta node's `[meta] https-insecure-certificate` configuration. This configuration is available in >= 1.12.3. * feat: https-insecure-certificate configuration (#6847) Add documentation for `https-insecure-certificate` configuration in `[cluster]` and `[http]` sections. * feat: [tls] advanced-expiration configuration (#6849) Add `[tls] advanced-expiration` setting for data nodes. * feat: add compression options to influxd-ctl backup (#6717) * feat: add compression options to influxd-ctl backup Added new flags for backup compression and performance tuning. * feat: Update backup.md Co-authored-by: Jason Stirnaman <jstirnaman@influxdata.com> * Update content/enterprise_influxdb/v1/tools/influxd-ctl/backup.md Co-authored-by: Scott Anderson <sanderson@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Scott Anderson <sanderson@users.noreply.github.com> --------- Co-authored-by: Jason Stirnaman <jstirnaman@influxdata.com> Co-authored-by: Scott Anderson <sanderson@users.noreply.github.com> * fix(enterprise): correct typos and inconsistencies in v1.12.3 release docs Fix grammar, formatting, and accuracy issues across the new v1.12.3 configuration and backup compression documentation. * fix(influxdb-v1): correct FUTURE LIMIT and PAST LIMIT clause order and add to ALTER RETENTION POLICY (#6591) * fix(influxdb-v1): correct FUTURE LIMIT and PAST LIMIT clause order and add to ALTER RETENTION POLICY - Fix clause order: FUTURE LIMIT must appear before PAST LIMIT (parser requirement) - Add FUTURE LIMIT and PAST LIMIT clauses to ALTER RETENTION POLICY syntax - Add grammar definitions for retention_future_limit and retention_past_limit - Add explicit note clarifying the required clause order - Fix "There are" style issue in spec.md closes #6590 * style(influxdb-v1): clean up InfluxQL spec formatting influxdb/v1: - Simplify introduction and use relative anchor links - Convert notes to GitHub-style callout syntax - Fix heading hierarchy (Letters/digits, Identifiers, Keywords, Literals as h3) - Standardize Duration units table heading - Fix "keywords" typo - Reword "See FAQ" to "For more information, see" - Simplify KILL QUERY section - Fix SHOW MEASUREMENT CARDINALITY heading level - Replace "There are" with active voice enterprise_influxdb/v1: - Add related links to frontmatter - Simplify introduction and use relative anchor links - Convert notes to GitHub-style callout syntax - Add Characters and Letters/digits to TOC - Standardize Duration units table heading - Fix "keywords" typo - Reword "See FAQ" to "For more information, see" - Simplify KILL QUERY section for Enterprise clusters - Update SHOW TAG KEYS grammar to include with_key_clause - Remove backticks from SHOW STATS headings * fix(influxdb-v1): address review issues in InfluxQL spec pages (#6931) * fix(influxdb-v1): address review issues in InfluxQL spec pages - Fix Enterprise KILL QUERY: restore proper EBNF grammar with optional ON clause and include both local and cluster examples - Fix duplicate "Durations" heading in both spec files - Fix list item spacing in Enterprise spec - Revert OSS heading level changes to maintain consistency with Enterprise - Restore Comments section to original location under Other in OSS spec * fix(influxdb-v1): move Comments section outside Other in OSS spec Match Enterprise spec structure: Comments is a top-level section before Other, not nested inside it. * fix(influxdb-v1): restore Comments link in OSS spec TOC * fix(influxdb-v1): rewrite KILL QUERY with clear Syntax and Examples sections Use text-typed code block for syntax notation and Syntax heading. Keep both local and cluster examples in sql-typed block. * feat(enterprise,v1): add v1.12.3 release notes and missing OSS config options Add release notes for InfluxDB v1.12.3 (OSS and Enterprise) with links to documented features. Add missing https-insecure-certificate and advanced-expiration config options to OSS docs. Fix backup example gzipBlockSize typo (10048576 → 10485760) and document the default. * fix(enterprise,v1): fix broken links in release notes and spec pages Fix 30+ broken links across v1 release notes and InfluxQL spec pages: - Correct config paths (configuration/ → configure/) - Fix fragment anchors (remove default values from anchors) - Update relocated pages (cluster-commands → tools/influxd-ctl) - Fix cross-product links (Enterprise → OSS for shared content) - Remove dead links (flux/v0.36, whats_new) * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * fix(enterprise,v1): move FUTURE/PAST LIMIT fix from Features to Bug fixes The clause order correction is a bug fix, not a new feature. * fix(v1): correct spec typos and KILL QUERY placeholder in v1.12.3 docs (#6932) * Initial plan * fix(v1): correct typos, grammar references, and example inconsistencies in spec and backup docs Co-authored-by: jstirnaman <212227+jstirnaman@users.noreply.github.com> * revert(enterprise/v1): restore gzipBlockSize and gzipBlockCount in backup example Co-authored-by: jstirnaman <212227+jstirnaman@users.noreply.github.com> * revert(v1): restore with_key_clause in spec grammar for show_tag_keys, show_tag_values_cardinality, and exact_cardinality statements Co-authored-by: jstirnaman <212227+jstirnaman@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jstirnaman <212227+jstirnaman@users.noreply.github.com> * fix(influxdb-v1): fix broken cross-references in meta-nodes config and OSS config - Fix meta-internal-shared-secret links in config-meta-nodes.md to point to config-data-nodes where the heading exists - Update MDN security headers URL to current location * chore(influxdb-v1): bump OSS and Enterprise latest patch to 1.12.3 * docs: tag v1.12.3-only config and backup updates (#6936) * Initial plan * docs(metadata): mark v1.12.3 additions Co-authored-by: jstirnaman <212227+jstirnaman@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jstirnaman <212227+jstirnaman@users.noreply.github.com> --------- Co-authored-by: Geoffrey Wossum <gwossum@influxdata.com> Co-authored-by: WeblWabl <devandbenz@gmail.com> Co-authored-by: Scott Anderson <sanderson@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Review fixes for #6591:
ONclause, add both local and cluster examples, fix list item spacing#### Durationsheading in both Enterprise and OSS spec files (restore##### Duration units/#### Duration units)Letters and digits,Identifiers,Keywords,Literalsand sub-headings) to maintain consistency with Enterprise specCommentssection to original location under## Otheras### Commentsin OSS specTest plan