Skip to content

fix(v1): publish OSS v1.12.3, defer Enterprise v1.12.3 pending GA#6945

Merged
jstirnaman merged 6 commits intomasterfrom
worktree-jts-fix-unpublish-ent-1.12.3
Mar 14, 2026
Merged

fix(v1): publish OSS v1.12.3, defer Enterprise v1.12.3 pending GA#6945
jstirnaman merged 6 commits intomasterfrom
worktree-jts-fix-unpublish-ent-1.12.3

Conversation

@jstirnaman
Copy link
Contributor

@jstirnaman jstirnaman commented Mar 14, 2026

Summary

  • Reverts the combined InfluxDB 1.12.3 release commit (InfluxDB 1.12.3 release #6872) that published both OSS and Enterprise docs simultaneously
  • Re-adds only OSS v1.12.3 documentation (release notes, config options, InfluxQL spec fixes)
  • Updates v1 release tooling (agent, PR template, command) to enforce separate OSS/Enterprise PRs going forward

Enterprise v1.12.2 docs fixes are in a separate PR to be merged after this one.
Enterprise v1.12.3 documentation is in a separate draft PR, pending GA in the portal.

Changes

Content (OSS v1 only)

  • content/influxdb/v1/about_the_project/release-notes.md — v1.12.3 release notes
  • content/influxdb/v1/administration/config.mdhttps-insecure-certificate and advanced-expiration config options
  • content/influxdb/v1/query_language/manage-database.md — FUTURE/PAST LIMIT clause order fix
  • content/influxdb/v1/query_language/spec.md — InfluxQL spec cleanup + ordering caution for pre-v1.12.3 users
  • data/products.yml — OSS version bump only (1.12.2 → 1.12.3); Enterprise stays at 1.12.2

Tooling

  • .claude/agents/influxdb1-tech-writer.md — added release documentation workflow section
  • .github/pull_request_template/influxdb_v1_release.md — separate OSS/Enterprise PRs, Enterprise pre-merge gate
  • .claude/commands/prepare-release-notes.md — v1 release workflow with separate PR examples

Test plan

  • Hugo build succeeds (npx hugo --quiet)
  • No Enterprise v1 content changes in diff
  • data/products.yml shows OSS at 1.12.3, Enterprise at 1.12.2
  • Link validation passes for OSS v1 content

…g GA

Revert the combined InfluxDB 1.12.3 release commit and re-add only
OSS v1.12.3 documentation. Enterprise v1.12.3 docs will be published
in a separate PR once the release artifact is GA in the portal.

Also adds FUTURE/PAST LIMIT ordering caution for users on versions
prior to v1.12.3 (from copilot/restore-ordering-warning-influxql).
Update the influxdb1-tech-writer agent, v1 release PR template, and
prepare-release-notes command to enforce the practice of always creating
separate PRs for OSS v1 and Enterprise v1 releases. Enterprise must wait
for GA in the portal before merging.
@jstirnaman jstirnaman requested a review from a team as a code owner March 14, 2026 18:16
@jstirnaman jstirnaman requested review from sanderson and removed request for a team March 14, 2026 18:16
@github-actions github-actions bot added product:v1 InfluxDB v1 OSS product:v1-enterprise InfluxDB Enterprise v1 labels Mar 14, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2026

PR Preview Action v1.4.8
🚀 Deployed preview to https://influxdata.github.io/docs-v2/pr-preview/pr-6945/
on branch gh-pages at 2026-03-14 20:04 UTC

@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2026

Preview Pages for Review

6 page(s) changed in this PR:

Preview URLs

@github-copilot please review the preview pages listed above using the template below:

Visual Review Prompt

Review the rendered documentation pages at the preview URLs listed below.
Check each page for visual and structural issues that are invisible in the
Markdown source.

Checklist

For each preview URL, verify:

  • No raw shortcodes — No {{< or {{% syntax visible on the page
  • No placeholder text — No PLACEHOLDER, TODO, FIXME, or
    template variables visible in rendered content
  • Layout intact — No overlapping text, missing images, or collapsed
    sections
  • Code blocks render correctly — No raw HTML fences or Markdown
    syntax visible inside code blocks
  • Product names correct — Page header, breadcrumbs, and sidebar show
    the correct product name
  • No 404s or errors — Page loads without error states
  • Navigation correct — Sidebar entries link to the right pages and
    the page appears in the expected location

Output

Follow the shared review comment format, severity definitions, and label
mapping in
templates/review-comment.md.

Adapt the "Files Reviewed" section to list preview URLs instead of file
paths.

Preview URLs

@jstirnaman jstirnaman added the release/v1 InfluxDB v1 OSS/Enterprise release documentation label Mar 14, 2026
Copy link
Contributor Author

@jstirnaman jstirnaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidby-influx Can you review the note in content/influxdb/v1/query_language/spec.md?
Enterprise content is restored to 1.12.2.

…luxQL spec

The revert of the combined v1.12.3 commit removed grammar production
definitions (retention_future_limit, retention_past_limit) that document
existing InfluxQL syntax, not v1.12.3-specific features. Restore them
so the grammar is complete.
Copy link

@davidby-influx davidby-influx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some reversions should not occur. Apologies.


```sql
CREATE DATABASE <database_name> [WITH [DURATION <duration>] [REPLICATION <n>] [SHARD DURATION <duration>] [FUTURE LIMIT <duration>] [PAST LIMIT <duration>] [NAME <retention-policy-name>]]
CREATE DATABASE <database_name> [WITH [DURATION <duration>] [REPLICATION <n>] [SHARD DURATION <duration>] [PAST LIMIT <duration>] [FUTURE LIMIT <duration>] [NAME <retention-policy-name>]]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct syntax is the FUTURE LIMIT PAST LIMIT in that order, so I think this fix should stand.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix in a separate PR

>non-string field values in the
>`WHERE` clause,
>[databases](/enterprise_influxdb/v1/concepts/glossary/#database), and
>[retention polices](/enterprise_influxdb/v1/concepts/glossary/#retention-policy-rp).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo, should be "policies"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate PR

for recommended configurations.

##### `FUTURE LIMIT` {metadata="v1.12.0+"}
##### `PAST LIMIT` {metadata="v1.12.0+"}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above, leave the correction.

The `ALTER RETENTION POLICY` query takes the following form, where you must declare at least one of the retention policy attributes `DURATION`, `REPLICATION`, `SHARD DURATION`, or `DEFAULT`:
```sql
ALTER RETENTION POLICY <retention_policy_name> ON <database_name> [DURATION <duration>] [REPLICATION <n>] [SHARD DURATION <duration>] [FUTURE LIMIT <duration>] [PAST LIMIT <duration>] [DEFAULT]
ALTER RETENTION POLICY <retention_policy_name> ON <database_name> [DURATION <duration>] [REPLICATION <n>] [SHARD DURATION <duration>] [DEFAULT]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would leave the previous syntax that includes FUTURE and PAST

-- specify the duration, future and past limits, and name of that retention policy
CREATE DATABASE "bar" WITH DURATION 1d FUTURE LIMIT 6h PAST LIMIT 6h NAME "myrp"
-- specify the duration, past and future limits, and name of that retention policy
CREATE DATABASE "bar" WITH DURATION 1d PAST LIMIT 6h FUTURE LIMIT 6h NAME "myrp"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous syntax, FUTURE, PAST order is correct

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prior bug, will fix in a separate PR

-- Create a retention policy and specify future and past limits.
CREATE RETENTION POLICY "10m.events" ON "somedb" DURATION 12h FUTURE LIMIT 6h PAST LIMIT 6h
-- Create a retention policy and specify past and future limits.
CREATE RETENTION POLICY "10m.events" ON "somedb" DURATION 12h PAST LIMIT 6h FUTURE LIMIT 6h

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous order, FUTURE, PAST is correct.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prior bug - will fix in a separate PR

> When using both `FUTURE LIMIT` and `PAST LIMIT` clauses, `FUTURE LIMIT` must appear before `PAST LIMIT`.

> [!Caution]
> **Prior to InfluxDB v1.12.3**, when using both `FUTURE LIMIT` and `PAST LIMIT` clauses,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is incorrect. Syntax is FUTURE, PAST; 1.12.3 fixes Enterprise meta-node recording of the limits, but not the syntax

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I see. There was a previous docs bug that had them reversed and I translated it to an actual syntax bug.

> [!Note]
> When using both `FUTURE LIMIT` and `PAST LIMIT` clauses, `FUTURE LIMIT` must appear before `PAST LIMIT`.

> [!Caution]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Order is FUTURE, PAST, but 1.12.3 fixes a bug that caused retention of the limits in Enterprise to fail silently.

… spec

The caution stated that prior to v1.12.3, PAST LIMIT must appear before
FUTURE LIMIT. This is incorrect — the correct syntax has always been
FUTURE LIMIT before PAST LIMIT. The v1.12.3 fix addresses Enterprise
meta-node recording of limits, not parser syntax order.
Copy link
Contributor Author

@jstirnaman jstirnaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Reverts enterprise changes completely. Pre-existing bugs will be fixed separately. Enterprise v1.12.3 docs will be released separately upon GA.

>non-string field values in the
>`WHERE` clause,
>[databases](/enterprise_influxdb/v1/concepts/glossary/#database), and
>[retention polices](/enterprise_influxdb/v1/concepts/glossary/#retention-policy-rp).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate PR

-- specify the duration, future and past limits, and name of that retention policy
CREATE DATABASE "bar" WITH DURATION 1d FUTURE LIMIT 6h PAST LIMIT 6h NAME "myrp"
-- specify the duration, past and future limits, and name of that retention policy
CREATE DATABASE "bar" WITH DURATION 1d PAST LIMIT 6h FUTURE LIMIT 6h NAME "myrp"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prior bug, will fix in a separate PR

-- Create a retention policy and specify future and past limits.
CREATE RETENTION POLICY "10m.events" ON "somedb" DURATION 12h FUTURE LIMIT 6h PAST LIMIT 6h
-- Create a retention policy and specify past and future limits.
CREATE RETENTION POLICY "10m.events" ON "somedb" DURATION 12h PAST LIMIT 6h FUTURE LIMIT 6h
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prior bug - will fix in a separate PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product:v1-enterprise InfluxDB Enterprise v1 product:v1 InfluxDB v1 OSS release/v1 InfluxDB v1 OSS/Enterprise release documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants