fix(v1): publish OSS v1.12.3, defer Enterprise v1.12.3 pending GA#6945
fix(v1): publish OSS v1.12.3, defer Enterprise v1.12.3 pending GA#6945jstirnaman merged 6 commits intomasterfrom
Conversation
This reverts commit 14e021a.
…g GA Revert the combined InfluxDB 1.12.3 release commit and re-add only OSS v1.12.3 documentation. Enterprise v1.12.3 docs will be published in a separate PR once the release artifact is GA in the portal. Also adds FUTURE/PAST LIMIT ordering caution for users on versions prior to v1.12.3 (from copilot/restore-ordering-warning-influxql).
Update the influxdb1-tech-writer agent, v1 release PR template, and prepare-release-notes command to enforce the practice of always creating separate PRs for OSS v1 and Enterprise v1 releases. Enterprise must wait for GA in the portal before merging.
|
Preview Pages for Review6 page(s) changed in this PR: Preview URLs
@github-copilot please review the preview pages listed above using the template below: Visual Review PromptReview the rendered documentation pages at the preview URLs listed below. ChecklistFor each preview URL, verify:
OutputFollow the shared review comment format, severity definitions, and label Adapt the "Files Reviewed" section to list preview URLs instead of file Preview URLs
|
jstirnaman
left a comment
There was a problem hiding this comment.
@davidby-influx Can you review the note in content/influxdb/v1/query_language/spec.md?
Enterprise content is restored to 1.12.2.
…luxQL spec The revert of the combined v1.12.3 commit removed grammar production definitions (retention_future_limit, retention_past_limit) that document existing InfluxQL syntax, not v1.12.3-specific features. Restore them so the grammar is complete.
…s in InfluxQL spec" This reverts commit c497f13.
davidby-influx
left a comment
There was a problem hiding this comment.
Some reversions should not occur. Apologies.
|
|
||
| ```sql | ||
| CREATE DATABASE <database_name> [WITH [DURATION <duration>] [REPLICATION <n>] [SHARD DURATION <duration>] [FUTURE LIMIT <duration>] [PAST LIMIT <duration>] [NAME <retention-policy-name>]] | ||
| CREATE DATABASE <database_name> [WITH [DURATION <duration>] [REPLICATION <n>] [SHARD DURATION <duration>] [PAST LIMIT <duration>] [FUTURE LIMIT <duration>] [NAME <retention-policy-name>]] |
There was a problem hiding this comment.
Correct syntax is the FUTURE LIMIT PAST LIMIT in that order, so I think this fix should stand.
There was a problem hiding this comment.
Will fix in a separate PR
| >non-string field values in the | ||
| >`WHERE` clause, | ||
| >[databases](/enterprise_influxdb/v1/concepts/glossary/#database), and | ||
| >[retention polices](/enterprise_influxdb/v1/concepts/glossary/#retention-policy-rp). |
| for recommended configurations. | ||
|
|
||
| ##### `FUTURE LIMIT` {metadata="v1.12.0+"} | ||
| ##### `PAST LIMIT` {metadata="v1.12.0+"} |
There was a problem hiding this comment.
As above, leave the correction.
| The `ALTER RETENTION POLICY` query takes the following form, where you must declare at least one of the retention policy attributes `DURATION`, `REPLICATION`, `SHARD DURATION`, or `DEFAULT`: | ||
| ```sql | ||
| ALTER RETENTION POLICY <retention_policy_name> ON <database_name> [DURATION <duration>] [REPLICATION <n>] [SHARD DURATION <duration>] [FUTURE LIMIT <duration>] [PAST LIMIT <duration>] [DEFAULT] | ||
| ALTER RETENTION POLICY <retention_policy_name> ON <database_name> [DURATION <duration>] [REPLICATION <n>] [SHARD DURATION <duration>] [DEFAULT] |
There was a problem hiding this comment.
I would leave the previous syntax that includes FUTURE and PAST
| -- specify the duration, future and past limits, and name of that retention policy | ||
| CREATE DATABASE "bar" WITH DURATION 1d FUTURE LIMIT 6h PAST LIMIT 6h NAME "myrp" | ||
| -- specify the duration, past and future limits, and name of that retention policy | ||
| CREATE DATABASE "bar" WITH DURATION 1d PAST LIMIT 6h FUTURE LIMIT 6h NAME "myrp" |
There was a problem hiding this comment.
Previous syntax, FUTURE, PAST order is correct
There was a problem hiding this comment.
Prior bug, will fix in a separate PR
| -- Create a retention policy and specify future and past limits. | ||
| CREATE RETENTION POLICY "10m.events" ON "somedb" DURATION 12h FUTURE LIMIT 6h PAST LIMIT 6h | ||
| -- Create a retention policy and specify past and future limits. | ||
| CREATE RETENTION POLICY "10m.events" ON "somedb" DURATION 12h PAST LIMIT 6h FUTURE LIMIT 6h |
There was a problem hiding this comment.
Previous order, FUTURE, PAST is correct.
There was a problem hiding this comment.
Prior bug - will fix in a separate PR
| > When using both `FUTURE LIMIT` and `PAST LIMIT` clauses, `FUTURE LIMIT` must appear before `PAST LIMIT`. | ||
|
|
||
| > [!Caution] | ||
| > **Prior to InfluxDB v1.12.3**, when using both `FUTURE LIMIT` and `PAST LIMIT` clauses, |
There was a problem hiding this comment.
I believe this is incorrect. Syntax is FUTURE, PAST; 1.12.3 fixes Enterprise meta-node recording of the limits, but not the syntax
There was a problem hiding this comment.
OK, I see. There was a previous docs bug that had them reversed and I translated it to an actual syntax bug.
| > [!Note] | ||
| > When using both `FUTURE LIMIT` and `PAST LIMIT` clauses, `FUTURE LIMIT` must appear before `PAST LIMIT`. | ||
|
|
||
| > [!Caution] |
There was a problem hiding this comment.
Order is FUTURE, PAST, but 1.12.3 fixes a bug that caused retention of the limits in Enterprise to fail silently.
… spec The caution stated that prior to v1.12.3, PAST LIMIT must appear before FUTURE LIMIT. This is incorrect — the correct syntax has always been FUTURE LIMIT before PAST LIMIT. The v1.12.3 fix addresses Enterprise meta-node recording of limits, not parser syntax order.
jstirnaman
left a comment
There was a problem hiding this comment.
👍 Reverts enterprise changes completely. Pre-existing bugs will be fixed separately. Enterprise v1.12.3 docs will be released separately upon GA.
| >non-string field values in the | ||
| >`WHERE` clause, | ||
| >[databases](/enterprise_influxdb/v1/concepts/glossary/#database), and | ||
| >[retention polices](/enterprise_influxdb/v1/concepts/glossary/#retention-policy-rp). |
| -- specify the duration, future and past limits, and name of that retention policy | ||
| CREATE DATABASE "bar" WITH DURATION 1d FUTURE LIMIT 6h PAST LIMIT 6h NAME "myrp" | ||
| -- specify the duration, past and future limits, and name of that retention policy | ||
| CREATE DATABASE "bar" WITH DURATION 1d PAST LIMIT 6h FUTURE LIMIT 6h NAME "myrp" |
There was a problem hiding this comment.
Prior bug, will fix in a separate PR
| -- Create a retention policy and specify future and past limits. | ||
| CREATE RETENTION POLICY "10m.events" ON "somedb" DURATION 12h FUTURE LIMIT 6h PAST LIMIT 6h | ||
| -- Create a retention policy and specify past and future limits. | ||
| CREATE RETENTION POLICY "10m.events" ON "somedb" DURATION 12h PAST LIMIT 6h FUTURE LIMIT 6h |
There was a problem hiding this comment.
Prior bug - will fix in a separate PR
Summary
Enterprise v1.12.2 docs fixes are in a separate PR to be merged after this one.
Enterprise v1.12.3 documentation is in a separate draft PR, pending GA in the portal.
Changes
Content (OSS v1 only)
content/influxdb/v1/about_the_project/release-notes.md— v1.12.3 release notescontent/influxdb/v1/administration/config.md—https-insecure-certificateandadvanced-expirationconfig optionscontent/influxdb/v1/query_language/manage-database.md— FUTURE/PAST LIMIT clause order fixcontent/influxdb/v1/query_language/spec.md— InfluxQL spec cleanup + ordering caution for pre-v1.12.3 usersdata/products.yml— OSS version bump only (1.12.2 → 1.12.3); Enterprise stays at 1.12.2Tooling
.claude/agents/influxdb1-tech-writer.md— added release documentation workflow section.github/pull_request_template/influxdb_v1_release.md— separate OSS/Enterprise PRs, Enterprise pre-merge gate.claude/commands/prepare-release-notes.md— v1 release workflow with separate PR examplesTest plan
npx hugo --quiet)data/products.ymlshows OSS at 1.12.3, Enterprise at 1.12.2