feat(dynamic): add dynamic wrapper function#5242
Merged
Conversation
6b0877e to
90d17b9
Compare
90d17b9 to
7b3a5c0
Compare
added 2 commits
September 29, 2022 10:07
Not really a good test. At this point, just verifying it can be imported and recieve an argument :(
7b3a5c0 to
6814e80
Compare
Contributor
Author
|
Apologies to @sanderson. I'd like to offer some practical examples in the docstring, but nothing will actually fly atm. I'll aim to loop back as we flesh out the functionality. |
sanderson
requested changes
Sep 29, 2022
Contributor
sanderson
left a comment
There was a problem hiding this comment.
Just some minor suggestions. Looks really good.
52d82ca to
a15db9a
Compare
Co-authored-by: Scott Anderson <sanderson@users.noreply.github.com>
a15db9a to
3e88f65
Compare
5 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally planned as a part of #5143, this diff adds a new builtin to the
experimental/dynamicpackage which wraps an existing value in aDynamic.This implementation is weak, probably incomplete, and hard to test without additional work since part of the contract of our "restrictive" dynamic type is you can't really do much with it until you cast it to some other value.
The buried lede is: we haven't implemented the dynamic support for the standard cast fns yet.
At this early stage the best I can offer in terms of testing is this short REPL session:
Checklist
Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.
experimental/docs/Spec.mdhas been updatedDear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.