Merged
Conversation
jsternberg
requested review from
Marwes and
jstirnaman
and removed request for
a team
jsternberg
force-pushed
the
feat/iox-sql-source
branch
from
ee135d1 to
1900bf7
Compare
jsternberg
force-pushed
the
feat/iox-sql-source
branch
from
1900bf7 to
7d2afab
Compare
sanderson
approved these changes
Oct 3, 2022
Contributor
sanderson
left a comment
sanderson
left a comment
There was a problem hiding this comment.
Approved, with one minor suggestion to the docs.
This adds an `iox.sql` function to `experimental/iox`. This function is powered by the iox dependency which defaults to an error provider. There's presently no default implementation of this dependency in this repository.
jsternberg
force-pushed
the
feat/iox-sql-source
branch
from
099d3a0 to
ce3f7b5
Compare
Marwes
approved these changes
Oct 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an
iox.sqlfunction toexperimental/iox. This function ispowered by the iox dependency which defaults to an error provider.
There's presently no default implementation of this dependency in this
repository.
Fixes #5203.
Checklist
Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.
experimental/docs/Spec.mdhas been updatedDear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.