Conversation
There was a problem hiding this comment.
Pull request overview
Fixes --json output for the v1 DBRP list command so it emits valid JSON (single JSON array) instead of interleaving JSON with human-readable section headers (per influxdb issue #24485).
Changes:
- Update
Client.Listto return early with a singlePrintJSON(...)whenPrintAsJSONis enabled. - Add a regression test that asserts
ListJSON output is valid JSON and contains the expected DBRPs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
clients/v1_dbrps/v1_dbrps.go |
Ensures JSON mode prints a single JSON array and avoids printing the virtual/physical section headers. |
clients/v1_dbrps/v1_dbrps_test.go |
Adds a JSON-focused test validating the list output is parseable JSON with expected entries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ae053bb to
ec59aa8
Compare
Fixes json output for dbrp, previously we had a plaintext header, this just outputs json:
example w/
jqusage (this would fail previously)closes: influxdata/influxdb#24485