Skip to content

Conversation

@rolincova
Copy link
Contributor

Closes #108

Replaced useless .ContinueWith in Api by direct call

  • CHANGELOG.md updated
  • Rebased/mergeable
  • Tests pass
  • Sign CLA (if not already signed)

@rolincova rolincova requested a review from bednar July 14, 2020 12:14
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2020

Codecov Report

Merging #110 into master will increase coverage by 0.01%.
The diff coverage is 3.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
+ Coverage   15.64%   15.65%   +0.01%     
==========================================
  Files          50       50              
  Lines        5000     4996       -4     
  Branches      253      253              
==========================================
  Hits          782      782              
+ Misses       4197     4193       -4     
  Partials       21       21              
Impacted Files Coverage Δ
Client/AuthorizationsApi.cs 0.00% <0.00%> (ø)
Client/BucketsApi.cs 0.53% <0.00%> (+<0.01%) ⬆️
Client/ChecksApi.cs 0.00% <0.00%> (ø)
Client/InfluxDBClient.cs 0.00% <0.00%> (ø)
Client/LabelsApi.cs 0.00% <0.00%> (ø)
Client/NotificationEndpointsApi.cs 0.00% <0.00%> (ø)
Client/NotificationRulesApi.cs 0.00% <0.00%> (ø)
Client/OrganizationsApi.cs 0.00% <0.00%> (ø)
Client/ScraperTargetsApi.cs 0.00% <0.00%> (ø)
Client/SourcesApi.cs 0.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 126a7be...9966849. Read the comment docs.

Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are another useless .ContinueWith calls. Check this patch:

useles-continue-with.txt

@bednar bednar changed the title refactor: Replaced useless .ContinueWith in Api by direct call (#108) fix: Replaced useless .ContinueWith in Api by direct call (#108) Jul 15, 2020
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bednar bednar added the bug Something isn't working label Jul 15, 2020
@bednar bednar added this to the 1.10.0 milestone Jul 15, 2020
@bednar bednar merged commit c35c505 into master Jul 15, 2020
@bednar bednar deleted the refactor/continue-with branch July 15, 2020 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor useless .ContinueWith in Api to direct call

4 participants