Skip to content

Conversation

@bednar
Copy link
Contributor

@bednar bednar commented Jul 4, 2022

Proposed Changes

Redacted Authorization HTTP header from log.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • dotnet test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2022

Codecov Report

Merging #330 (c8747a1) into master (7cc2413) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
+ Coverage   87.36%   87.37%   +0.01%     
==========================================
  Files          76       76              
  Lines        6631     6637       +6     
==========================================
+ Hits         5793     5799       +6     
  Misses        838      838              
Impacted Files Coverage Δ
Client.Core/Internal/LoggingHandler.cs 97.72% <100.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cc2413...c8747a1. Read the comment docs.

@bednar bednar requested a review from rhajek July 4, 2022 05:00
@bednar bednar marked this pull request as ready for review July 4, 2022 05:00
@bednar bednar merged commit 6f4d381 into master Jul 14, 2022
@bednar bednar deleted the authorization-header-redacted branch July 14, 2022 12:27
@bednar bednar added this to the 4.4.0 milestone Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants