Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
## 4.4.0 [unreleased]

### Bug Fixes
1. [#330](https://github.com/influxdata/influxdb-client-csharp/pull/330): Redact the `Authorization` HTTP header from log

## 4.3.0 [2022-06-24]

### Features
Expand Down
8 changes: 7 additions & 1 deletion Client.Core/Internal/LoggingHandler.cs
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,13 @@ private void LogHeaders(IEnumerable<HeaderParameter> headers, string direction,
return;
}

foreach (var emp in headers) Trace.WriteLine($"{direction} {type}: {emp.Name}={emp.Value}");
foreach (var emp in headers)
{
var value = string.Equals(emp.Name, "Authorization", StringComparison.OrdinalIgnoreCase)
? "***"
: emp.Value;
Trace.WriteLine($"{direction} {type}: {emp.Name}={value}");
}
}
}
}
25 changes: 25 additions & 0 deletions Client.Test/InfluxDbClientTest.cs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
using System;
using System.Collections.Generic;
using System.Diagnostics;
using System.IO;
Expand Down Expand Up @@ -416,5 +417,29 @@ public void TestMocking()
var tables = mockClient.Object.GetQueryApiSync().QuerySync("from(...", "my-org");
Assert.AreEqual(mockTables, tables);
}

[Test]
public void RedactedAuthorizationHeader()
{
_client.Dispose();
_client = InfluxDBClientFactory.Create(MockServerUrl, "my-token");

var writer = new StringWriter();
Trace.Listeners.Add(new TextWriterTraceListener(writer));

_client.SetLogLevel(LogLevel.Headers);

MockServer
.Given(Request.Create().WithPath("/api/v2/write").UsingPost())
.RespondWith(CreateResponse("{}"));

using (var writeApi = _client.GetWriteApi())
{
writeApi.WriteRecord("h2o_feet,location=coyote_creek water_level=1.0 1", WritePrecision.Ns, "b1",
"org1");
}

StringAssert.Contains("Header: Authorization=***", writer.ToString());
}
}
}