Skip to content

Revert "fix: use g17 format for doubles (#434)" #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Revert "fix: use g17 format for doubles (#434)" #467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
## 4.11.0 [unreleased]

### Bug Fixes
- Revert [#408] conversion of double to string can result in a loss of precision

## 4.10.0 [2023-01-26]

### Bug Fixes
Expand Down
6 changes: 2 additions & 4 deletions Client.Test/MeasurementMapperTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,7 @@ public void ColumnWithoutName()

var lineProtocol = _mapper.ToPoint(poco, WritePrecision.S).ToLineProtocol();

Assert.AreEqual(
"poco,tag=tag\\ val value=15.444000000000001,ValueWithEmptyName=25,ValueWithoutDefaultName=20i 864000",
Assert.AreEqual("poco,tag=tag\\ val value=15.444,ValueWithEmptyName=25,ValueWithoutDefaultName=20i 864000",
lineProtocol);
}

Expand Down Expand Up @@ -112,8 +111,7 @@ public void MeasurementProperty()

var lineProtocol = _mapper.ToPoint(poco, WritePrecision.S).ToLineProtocol();

Assert.AreEqual(
"poco,tag=tag\\ val value=15.444000000000001,ValueWithEmptyName=25,ValueWithoutDefaultName=20i 864000",
Assert.AreEqual("poco,tag=tag\\ val value=15.444,ValueWithEmptyName=25,ValueWithoutDefaultName=20i 864000",
lineProtocol);
}

Expand Down
19 changes: 1 addition & 18 deletions Client.Test/PointDataTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,24 +149,7 @@ public void FieldTypes()

var expected =
"h2o,location=europe boolean=false,byte=9i,decimal=25.6,double=250.69,float=35,integer=7i,long=1i," +
"point=13.300000000000001,sbyte=12i,short=8i,string=\"string value\",uint=11u,ulong=10u,ushort=13u";

Assert.AreEqual(expected, point.ToLineProtocol());
}

[Test]
public void DoubleFormat()
{
var point = PointData.Measurement("sensor")
.Field("double", 250.69D)
.Field("double15", 15.333333333333333D)
.Field("double16", 16.3333333333333333D)
.Field("double17", 17.33333333333333333D)
.Field("example", 459.29587181322927);

var expected =
"sensor double=250.69,double15=15.333333333333332,double16=16.333333333333332," +
"double17=17.333333333333332,example=459.29587181322927";
"point=13.3,sbyte=12i,short=8i,string=\"string value\",uint=11u,ulong=10u,ushort=13u";

Assert.AreEqual(expected, point.ToLineProtocol());
}
Expand Down
7 changes: 1 addition & 6 deletions Client/Writes/PointData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,15 +472,10 @@ private bool AppendFields(StringBuilder sb)
EscapeKey(sb, key);
sb.Append('=');

if (value is float)
if (value is double || value is float)
{
sb.Append(((IConvertible)value).ToString(CultureInfo.InvariantCulture));
}
else if (value is double)
{
var valueStr = ((double)value).ToString("G17", CultureInfo.InvariantCulture);
sb.Append((IConvertible)valueStr);
}
else if (value is uint || value is ulong || value is ushort)
{
sb.Append(((IConvertible)value).ToString(CultureInfo.InvariantCulture));
Expand Down