Skip to content

Conversation

@bednar
Copy link
Contributor

@bednar bednar commented Jun 23, 2021

Closes #273

Proposed Changes

  • Fixed building docs
  • Added CircleCI check for Sphinx docs

Checklist

  • Rebased/mergeable
  • pytest tests completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review June 23, 2021 19:18
@bednar bednar requested a review from rhajek June 23, 2021 19:18
@bednar bednar changed the title feat: add check for sphinx docs fix: building check for sphinx docs Jun 23, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2021

Codecov Report

Merging #275 (f2a2db7) into master (dc88ee9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #275   +/-   ##
=======================================
  Coverage   92.58%   92.58%           
=======================================
  Files          27       27           
  Lines        2158     2158           
=======================================
  Hits         1998     1998           
  Misses        160      160           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc88ee9...f2a2db7. Read the comment docs.

@bednar bednar changed the title fix: building check for sphinx docs fix: building sphinx docs Jun 23, 2021
@rhajek rhajek merged commit 7a12973 into master Jun 24, 2021
@rhajek rhajek deleted the fix/sphinx branch June 24, 2021 07:26
@bednar bednar added this to the 1.19.0 milestone Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

readthedocs build is failing

4 participants