CLI arguments for specifying IO/Datafusion threads are inconsistent between Core/Enterprise

[hiltontj]

Problem

There are two args for specifying IO and Datafusion thread allocations, respectively:

• --num-threads
• --datafusion-num-threads

In Enterprise, these are:

• --num-io-threads
• --num-datafusion-threads

This is inconsistent and therefore incompatible.

Proposed solution

Use the argument names from Enterprise, but keep the existing argument names as aliases. That would require changes to this macro to accept a num_threads_arg_alias argument.

The environment variables are also different between Core and Enterprise, so we may need to figure out if it is possible to do similar kind of aliasing for environment variables, so that Core to Enterprise is compatible.

[stuartcarnie]

Couldn't figure out why influxdb_pro was showing --num-datafusion-threads in the help output:

influxdb3 --help-all

  --num-io-threads <N>               Set maximum IO runtime threads
                                     [env: INFLUXDB3_NUM_IO_THREADS=]

  --num-datafusion-threads <N>       Set maximum Datafusion runtime threads
                                     [env: INFLUXDB3_NUM_DATAFUSION_THREADS=]

As only the TokioIoConfig struct is included in the main command. Found it in the influxdb3_all.txt content 😅

[stuartcarnie]

I found that args can specify alias for long flags, so I'll use that. For environment variables, there isn't an obvious solution, so we'll have to go with something manual like checking the environment and copying the values manually. We'll need to ensure the environment variables are mutually exclusive.