ResourceSync status should be updated on success, not just on failure

[lukebond]

it would be nice to know if sinker has processed a ResourceSync successfully. currently you have to grep the logs to know. the status is updated on error but not on success. there appears to be code to do it but it's not doing anything. see here.

[zach-robinson-dev]

The expected behavior at the moment should be that the ResourceSyncFailing condition gets removed once the sync succeeds. Is that not what is happening?

[lukebond]

given we have a negative polarity status condition, as zach points out, this isn't required.