docs(inputs.openntpd): Correct timeout config setting to the actually used default#16666
docs(inputs.openntpd): Correct timeout config setting to the actually used default#16666mstrandboge merged 4 commits intoinfluxdata:masterfrom
Conversation
|
Thanks so much for the pull request! |
|
@msimerson could you please sign the CLA and run |
|
!signed-cla |
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
srebhan
left a comment
There was a problem hiding this comment.
@msimerson thanks for taking care. One comment. Furthermore, could you please rebase on the latest master to get CI fixed?
up the config timeout from 5ms to 50ms
srebhan
left a comment
There was a problem hiding this comment.
Thanks for the fix @msimerson!
up the config timeout from a ridiculous 5ms to 1s.
The timeout embedded in the code is 5 seconds, so perhaps that's what the config should be?
Summary
5 ms causes the collector to time out before ntpctl returns, and it returns very very fast. Also, it's too easy for humans reading the config to not notice the units are
msunits and notsunits.Checklist
Related issues