feat: add pagination to Dashboard page #3403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hoorayimhelping
approved these changes
Dec 9, 2021
Contributor
hoorayimhelping
left a comment
hoorayimhelping
left a comment
There was a problem hiding this comment.
Awesome work! Looks great and works consistently with the other paginated resources!
After this gets promoted to our internal environments, let's meet up to flip the feature flag
| <> | ||
| <ResourceList style={{width: this.props.pageWidth}}> | ||
| <ResourceList.Body | ||
| style={{maxHeight: height, minHeight: height, overflow: 'auto'}} |
Contributor
There was a problem hiding this comment.
cool, this overflow: 'auto' avoids the bug I keep seeming to stumble over.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3386
Added pagination to Dashboards.
before pagination:
Screen.Recording.2021-12-08.at.1.45.04.PM.mov
After pagination:
https://user-images.githubusercontent.com/66275100/145273990-99a3d393-d37b-4924-b378-479e259748c3.mov