♻️ refactor(file-manager): improve locking and writing logic for file…#3
Merged
♻️ refactor(file-manager): improve locking and writing logic for file…#3
Conversation
… operations - Updated `SafeFileReader` to ensure locks are released only when files are properly initialized. - Enhanced the `SafeFileWriter` lock mechanism to increase retries from 3 to 5 and delay from 100ms to 200ms for better robustness. - Removed redundant try-finally block in the `__call` method of `SafeFileWriter`. - Changed write methods to return the actual number of bytes written (`int|false`) instead of boolean, improving API clarity and usability. - Added exceptions to the destructor in `SafeFileWriter` to handle potential resource issues during cleanup. BREAKING CHANGE: Modified the return type of multiple private write methods in `SafeFileWriter` from `bool` to `int|false`. This impacts integrations relying on previous boolean responses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… operations
SafeFileReaderto ensure locks are released only when files are properly initialized.SafeFileWriterlock mechanism to increase retries from 3 to 5 and delay from 100ms to 200ms for better robustness.__callmethod ofSafeFileWriter.int|false) instead of boolean, improving API clarity and usability.SafeFileWriterto handle potential resource issues during cleanup.BREAKING CHANGE: Modified the return type of multiple private write methods in
SafeFileWriterfrombooltoint|false. This impacts integrations relying on previous boolean responses.