feat(ui): implemented additional property changing of orderable and c… #102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant refactoring and expansion of the command structure within the
OrderContextmodule, along with some minor improvements and renaming for clarity. The main focus is on making the command types and their handling more expressive, granular, and consistent, especially for various orderable and component property adjustments. Additionally, function names related to constraints are clarified across the codebase.Key changes:
Command Structure Refactoring and Expansion
OrderContext.Commanddiscriminated union to introduce more granular and consistently named commands for schedule frequency, orderable dose/quantity/rate, and component quantity property adjustments. This includes replacing previous commands with new ones such asDecreaseScheduleFrequencyProperty,IncreaseOrderableDoseQuantityProperty, andDecreaseComponentQuantityProperty, among others.Naming and Function Signature Improvements
setConstraintstosetMinMaxConstraintsthroughout theMedicationmodule for improved clarity and consistency. [1] [2] [3]Type and Helper Adjustments
logGenFormMessagesto useGenFormResult<_>directly for improved clarity.These changes collectively improve the maintainability, extensibility, and clarity of the order management logic, making it easier to add new command types and reason about property adjustments in the future.