Skip to content

Upgrade fable5#323

Merged
halcwb merged 2 commits intoinformedica:masterfrom
halcwb:upgrade-fable5
Apr 22, 2026
Merged

Upgrade fable5#323
halcwb merged 2 commits intoinformedica:masterfrom
halcwb:upgrade-fable5

Conversation

@halcwb
Copy link
Copy Markdown
Collaborator

@halcwb halcwb commented Apr 22, 2026

This pull request updates several dependencies to their latest stable versions, improving compatibility and ensuring access to recent features and bug fixes. The main changes involve upgrading Fable and related F# libraries, as well as build and testing tools.

Dependency upgrades:

  • Upgraded Fable tool version from 5.0.0-rc.5 to the stable 5.0.0 in .config/dotnet-tools.json.
  • Updated multiple NuGet packages in paket.dependencies, including:
    • FSharpPlus from 1.7.0 to 1.9.1
    • Fable.Core from 5.0.0-rc.1 to 5.0.0
    • Fable.Elmish.React from 5.5.0-beta-1 to 5.6.0
    • Fable.Elmish.HMR from 9.0.0-beta.1 to 9.0.0
    • NJsonSchema from 11.6.0 to 11.6.1

Build and test tooling updates:

  • Upgraded Fake.Core.Target and Fake.IO.FileSystem from 6.1.3 to 6.1.4, and Microsoft.Net.Test.Sdk from 18.3.0 to 18.4.0.
  • Updated Markdig from 0.42.0 to 1.1.3 for improved Markdown parsing and features.

Other:

  • Minor formatting adjustment in the paket.dependencies file.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 22, 2026

Greptile Summary

This PR promotes pre-release Fable/Elmish packages to stable releases and bumps several other dependencies to their latest versions. Most upgrades are low-risk patch or RC→stable promotions, but two stand out as needing explicit verification:

  • Markdig 0.42 → 1.1.3: crosses the 0.x→1.x boundary; Markdig 1.0 explicitly removed previously-deprecated APIs.
  • FSharpPlus 1.7 → 1.9.1: skips an entire minor series (1.8.x); FSharpPlus is known to make breaking changes between minor versions, and multiple production modules depend on it.

Confidence Score: 4/5

Safe to merge once a full build and test pass is confirmed for the two notable version jumps (Markdig and FSharpPlus).

The majority of changes are straightforward RC-to-stable or patch upgrades. The two P1 items (Markdig major bump and FSharpPlus two-minor-version jump) are not guaranteed to break anything — the Markdig usage is minimal and the affected API is stable — but they cannot be ruled out without a successful build and test run.

paket.dependencies — Markdig and FSharpPlus version jumps warrant explicit CI/build verification.

Important Files Changed

Filename Overview
.config/dotnet-tools.json Fable tool promoted from RC5 to stable 5.0.0; newline added at end of file.
paket.dependencies Multiple dependency upgrades including Markdig 0.42→1.1.3 (major version jump with known API removals) and FSharpPlus 1.7→1.9.1 (two minor versions); other upgrades move pre-release versions to stable.
paket.lock Lock file consistently updated to reflect the resolved dependency versions declared in paket.dependencies.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR: Upgrade Fable5 deps] --> B[Low-risk upgrades]
    A --> C[Higher-risk upgrades]

    B --> B1[Fable 5.0.0-rc.5 → 5.0.0 stable]
    B --> B2[Fable.Core rc.1 → 5.0.0 stable]
    B --> B3[Fable.Elmish.React beta → 5.6.0]
    B --> B4[Fable.Elmish.HMR beta → 9.0.0]
    B --> B5[Fake 6.1.3 → 6.1.4]
    B --> B6[NJsonSchema 11.6.0 → 11.6.1]
    B --> B7[Microsoft.Net.Test.Sdk 18.3 → 18.4]

    C --> C1["Markdig 0.42 → 1.1.3\n⚠️ Major version, obsolete APIs removed"]
    C --> C2["FSharpPlus 1.7.0 → 1.9.1\n⚠️ Skips 1.8.x series, breaking changes possible"]

    C1 --> D[src/Informedica.ZForm.Lib/Markdown.fs\nuses Markdown.ToHtml — stable API]
    C2 --> E[Extraction.fs, WebSiteParser.fs,\nFormularyParsers.fs, OpenAI.fs,\nOllama.fs, Fireworks.fs]
Loading

Comments Outside Diff (1)

  1. paket.dependencies, line 46 (link)

    P1 Markdig major version bump may remove APIs

    Markdig jumps from 0.42.0 to 1.1.3, which crosses a major version boundary. The 1.0 release explicitly removed previously-deprecated APIs (Remove obsolete APIs — PR #926). Markdown.fs calls Markdown.ToHtml(s) which is the core stable API and is almost certainly unaffected, but any other usages (e.g. custom pipeline extensions, renderer types, or AST mutation APIs) could silently fail to compile or change behavior. Please verify that all build targets and tests pass after this upgrade before merging.

    Fix in Claude Code

Fix All in Claude Code

Reviews (1): Last reviewed commit: "chore: update additional packages" | Re-trigger Greptile

Comment thread paket.dependencies
@halcwb halcwb merged commit 4a97029 into informedica:master Apr 22, 2026
22 checks passed
@halcwb halcwb deleted the upgrade-fable5 branch April 22, 2026 07:55
halcwb added a commit that referenced this pull request Apr 23, 2026
…-20260422-cba508584ac43cbf

[Repo Assist] docs(changelog): document PRs #323#325 Fable 5 upgrade, client deps, and parenteralia print fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant