Skip to content

Conversation

leifmadsen
Copy link
Member

Closes STF-1283

@leifmadsen leifmadsen added the do not merge Code is not ready to be merged label Mar 27, 2023
@leifmadsen leifmadsen requested a review from mickogeary March 27, 2023 20:18
@leifmadsen
Copy link
Member Author

@mickogeary we can talk about this Thursday or sometime this week. Take a look and let me know if this approach makes sense to you. I'm going to merge the master branch into stable-1.5 though which is why I have this as draft and "do not merge" label. Once I've merged down to stable-1.5 then we can review and merge this down in preparation for creating the procedures, or perhaps create a new branch from this, not sure which way to go about it yet.

@leifmadsen leifmadsen force-pushed the stf-1283/refactor_for_ospdo branch from 39e431d to 826ba96 Compare April 19, 2023 14:34
@leifmadsen
Copy link
Member Author

I just rebased this against master

@leifmadsen leifmadsen marked this pull request as ready for review April 27, 2023 12:53
@leifmadsen
Copy link
Member Author

Talking with Michael, we're going to merge this down so he can just pull the contents and then start adding his updates over the next week or so.

@leifmadsen leifmadsen merged commit 7a3aba2 into master Apr 27, 2023
@leifmadsen leifmadsen deleted the stf-1283/refactor_for_ospdo branch April 27, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge Code is not ready to be merged

Development

Successfully merging this pull request may close these issues.

2 participants