import/master to stable 1 5 #480
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
leifmadsen
commented
Jun 19, 2023
leifmadsen
commented
- Add procedure to disable services on OSP side (Add procedure to disable services on OSP side #407)
- Don't remove existing 'stable-1.5' generated files (Don't remove existing 'stable-1.5' generated files #412)
- Minor updates to dashboarding guide (Minor updates to dashboarding guide #413)
- Fix syntax error in certificate renewal module (Fix syntax error in certificate renewal module #416)
- Removed sending-metrics-to-gnocchi-and-to-stf m… (Removed sending-metrics-to-gnocchi-and-to-stf m… #414)
- Jof mas minor edits 1.5 (Jof mas minor edits 1.5 #421)
- Update link to STF life cycle page (Update link to STF life cycle page #423)
- updated link (updated link #428)
- Updated path to match PR#52 in dashboard repo (Updated path to match PR#52 in dashboard repo #427)
- Fixed alertmanager verification command (Fixed alertmanager verification command #430)
- Eliminate mentions of sensubility in OSP13 (Eliminate mentions of sensubility in OSP13 #431)
- A list of low hanging docs changes from our feature testing (A list of low hanging docs changes from our feature testing #426)
- mg_master_2161659_minor-style-edit changed note text and position (mg_master_2161659_minor-style-edit changed note text and position #437)
- Remove note from importing dashboards procedure (Remove note from importing dashboards procedure #439)
- Adjust network polling meter for ceilometer (Adjust network polling meter for ceilometer #440)
- Eliminate vestiges of "stf-default" (Eliminate vestiges of "stf-default" #442)
- Link to the amqp1 plugin header directly (Link to the amqp1 plugin header directly #443)
- Bump base image for building to Fedora 37 (Bump base image for building to Fedora 37 #445)
- mg_master_2168184_adding section with procedures for upgrade from 1.4… (mg_master_2168184_adding section with procedures for upgrade from 1.4… #444)
- Fix alertmanager verification command
- Revert "Fix alertmanager verification command"
- Fix alertmanager verification command (Fix alertmanager verification command #450)
- Reference event enablement for virtual machine view (Reference event enablement for virtual machine view #451)
- Expand supported OCP range through to 4.12 (Expand supported OCP range through to 4.12 #452)
- Adjust path to triple-ansible-inventory file (Adjust path to triple-ansible-inventory file #454)
- Remove DCN related configuration artifacts (Remove DCN related configuration artifacts #455)
- Add SNMP trap configuration parameters (Add SNMP trap configuration parameters #449)
- Expose ability to set certificate renewal target times (Expose ability to set certificate renewal target times #453)
- [OSP13] Replacing "allovercloud" with "overcloud" in ansible command ([OSP13] Replacing "allovercloud" with "overcloud" in ansible command #456)
- [OSP13] Replacing podman with docker in ansible command. ([OSP13] Replacing podman with docker in ansible command. #457)
- Use Prometheus Operator from Red Hat CatalogSource (Use Prometheus Operator from Red Hat CatalogSource #460)
- Initial refactoring for director Operator support (Initial refactoring for director Operator support #458)
- mg master 1195 add OSPdO content incl 3 new modules (mg master 1195 add OSPdO content incl 3 new modules #461)
- mg_master_2187300_few_DDFs_edits another attempt to push (mg_master_2187300_few_DDFs_edits another attempt to push #463)
- Drop reference to ephemeral storage (Drop reference to ephemeral storage #464)
- Remove reference to lokistack (Remove reference to lokistack #466)
- Fix issues with links (Fix issues with links #465)
- Clarify topic configuration in stf-connectors.yaml (Clarify topic configuration in stf-connectors.yaml #467)
- Fix invalid oc edit command (Fix invalid oc edit command #468)
- Fix acronym usage (Fix acronym usage #471)
- Migrate to using community-operators (Migrate to using community-operators #470)
- Refer to AMQ Interconnect version more loosely (Refer to AMQ Interconnect version more loosely #473)
- clean up deployment step Closes: rhbz#2187302 (clean up deployment step Closes: rhbz#2187302 #469)
- Minor clean up (Minor clean up #474)
- removed info and example about overriding default Elasticsearch config (removed info and example about overriding default Elasticsearch config #476)
- Clarify which OCP to get the AMQ route from (Clarify which OCP to get the AMQ route from #478)
- Output clean up and minor clarity changes (Output clean up and minor clarity changes #475)
- Clarify some ambiguity with which OCP to login to (Clarify some ambiguity with which OCP to login to #479)
* Add procedure to disable services on OSP side Add a procedure that disables the services provisioned when enabling STF. Resolves: rhbz#2096853 * Add warning to not use procedure with gnocchi Add a warning to not use the disable procedure when making use of the Sending metrics to Gnocchi and Service Telemetry Framework procedure since not all dependencies are provided as part of that instruction set, since they are a super-set of the STF deployment instructions. In the future we should probably just remove the Gnocchi deployment instructions since we've re-written the autoscaling guide and that is the one procedure that would provide Gnocchi deployments, and would contain all the necessary dependencies in the provided THT environment files. * Apply suggestions from code review Small changes from jof * Update doc-Service-Telemetry-Framework/modules/proc_disabling-openstack-services-used-with-stf.adoc Co-authored-by: JoanneOFlynn2018 <45287002+JoanneOFlynn2018@users.noreply.github.com> * Update doc-Service-Telemetry-Framework/modules/proc_disabling-openstack-services-used-with-stf.adoc Co-authored-by: JoanneOFlynn2018 <45287002+JoanneOFlynn2018@users.noreply.github.com> * Update doc-Service-Telemetry-Framework/modules/proc_disabling-openstack-services-used-with-stf.adoc Co-authored-by: JoanneOFlynn2018 <45287002+JoanneOFlynn2018@users.noreply.github.com> Co-authored-by: JoanneOFlynn2018 <45287002+JoanneOFlynn2018@users.noreply.github.com> (cherry picked from commit 20d6f11)
Update the upstream portions of the documentation to refer to the new stable-1.5 channels which are part of the new infrawatch-catalog index image with the nightly-1.5 tag, which references built artifacts created from the stable-1.5 branch of the various STF components.
* Build and push documentation for STF 1.5 Update scripts and path references for STF 1.5 so that we can have upstream documentation for this release. Going forward major changes will happen in the main branch in preparation for STF 2.0. It will be good to have a current version of documentation for the stable-1.5 branch which will reference the new release automation changes that provides an upstream nightly build for stable-1.5 in its own index image. * Don't attempt to move non-existant file
* Minor updates to dashboarding guide Perform some minor updates to the dashboarding guide, referencing existing dashboards we have for virtual machine and memcached views. Update the ServiceTelemetry manifest to reference the rhel8/grafana:7 container image which should provide more consistency in how things are deployed, helping avoid a situation where newer versions of Grafana out of hub.docker.com no longer interface with the version of Elasticsearch that would be used when enabling events support by default. Update the path to the dashboards being created to reference the 'stf-1/' directory to reduce confusion by no longer referencing stf-1.3 in the links. Depends-On: infrawatch/dashboards#50 * Update doc-Service-Telemetry-Framework/modules/con_dashboards.adoc plural to single * Update doc-Service-Telemetry-Framework/modules/proc_setting-up-grafana-to-host-the-dashboard.adoc * Add note about STF 1.3 and revert path change Revert path changes to the dashboards as use of symlinks as intended is not possible. Instead, add a note stating that the reference to STF 1.3 is the earliest version compatible with the dashboards, and can be used with STF versions 1.3 through 1.5. Co-authored-by: JoanneOFlynn2018 <45287002+JoanneOFlynn2018@users.noreply.github.com> (cherry picked from commit e23a1b3)
* Fix syntax error in certificate renewal module Fix a syntax error in the certificate renewal module. Fixing this results in another issue that was hidden, whereby extra source lines are shown when building for version 17.0 due to loose version ranges. Unfortunately asciidoc doesn't provide an AND function in an ifeval or ifdef so we need separate parameters defined and nested to perform what is effectively a greater-than AND less-than evaluation. This was caught by QE when identifying a link that didn't have a corresponding section being built. The syntax error on the endif resulted in everything after that not being built, but did not result in a build error oddly enough. With this fix, everything is working as intended and included assemblies after this one are now visible. * Update ifdef to use AND syntax Update ifdef to use AND syntax per https://docs.asciidoctor.org/asciidoc/latest/directives/ifdef-ifndef/#checking-multiple-attributes (cherry picked from commit 1a6cecf)
* Removed xrefs and include for sending-metrics-to-gnocchi-and-to-stf module * New folder named departure to hold files before deletion, updated gitignore file * I removed an assembly xref from additional resources section so that build is 100% * Removed upgrade section * Added link at assembly level re disabling services Co-authored-by: Leif Madsen <lmadsen@redhat.com> Co-authored-by: Leif Madsen <lmadsen@redhat.com>
Update the link to the STF life cycle page and remove reference to supporting the two most recent versions of STF. This has recently changed. STF 1.4 will be supported until the EOL of OpenShift 4.8 at which point STF 1.4 will also be EOL. In the meantime STF 1.4 is now in maintenance mode (CVE fixes only, no backport of features). STF 1.5 is supported as of 4.10 and will EOL with RHOSP 17.1. (cherry picked from commit 2e3fd4b)
…) (#438) Co-authored-by: Michael Geary <mgeary@redhat.com> Co-authored-by: Michael Geary <mgeary@redhat.com>
* Bump base image for building to Fedora 37 Bump the base image for building in CI to Fedora 37 because Fedora 33 is now EOL and has been removed from the quay repository. * Set /docs directory to being marked safe * Bump actions/checkout v2 (deprecated) to v3
#444) (#448) * mg_master_2168184_adding section with procedures for upgrade from 1.4 to 1.5 * Bump base image for building to Fedora 37 (#445) * Bump base image for building to Fedora 37 Bump the base image for building in CI to Fedora 37 because Fedora 33 is now EOL and has been removed from the quay repository. * Set /docs directory to being marked safe * Bump actions/checkout v2 (deprecated) to v3 * Update doc-Service-Telemetry-Framework/assemblies/assembly_upgrading-service-telemetry-framework-to-version-1-5.adoc * commit 2, incorporating feedback mg_master_2168184_procedures-to-upgrade-from-1.4-to-1.5 * commit 3, fixed internal link to Grafana section mg_master_2168184_procedures-to-upgrade-from-1.4-to-1.5 * mg_master_2168184_procedures-to-upgrade-from-1.4-to-1.5 commit Feb 14th * Add ifdef wrappers for certificate parts (#447) * Add ifdef wrappers for certificate documentation parts which do not apply to OSP16 (only 13 and 17). * Add a couple of clean up items for consistency and visual bits. * mg_master_2168184_procedures-to-upgrade-from-1.4-to-1.5 commit Feb 17 Rebased --------- Co-authored-by: Leif Madsen <lmadsen@redhat.com>
* Add procedure to disable services on OSP side (#407) * Add procedure to disable services on OSP side Add a procedure that disables the services provisioned when enabling STF. Resolves: rhbz#2096853 * Add warning to not use procedure with gnocchi Add a warning to not use the disable procedure when making use of the Sending metrics to Gnocchi and Service Telemetry Framework procedure since not all dependencies are provided as part of that instruction set, since they are a super-set of the STF deployment instructions. In the future we should probably just remove the Gnocchi deployment instructions since we've re-written the autoscaling guide and that is the one procedure that would provide Gnocchi deployments, and would contain all the necessary dependencies in the provided THT environment files. * Apply suggestions from code review Small changes from jof * Update doc-Service-Telemetry-Framework/modules/proc_disabling-openstack-services-used-with-stf.adoc Co-authored-by: JoanneOFlynn2018 <45287002+JoanneOFlynn2018@users.noreply.github.com> * Update doc-Service-Telemetry-Framework/modules/proc_disabling-openstack-services-used-with-stf.adoc Co-authored-by: JoanneOFlynn2018 <45287002+JoanneOFlynn2018@users.noreply.github.com> * Update doc-Service-Telemetry-Framework/modules/proc_disabling-openstack-services-used-with-stf.adoc Co-authored-by: JoanneOFlynn2018 <45287002+JoanneOFlynn2018@users.noreply.github.com> Co-authored-by: JoanneOFlynn2018 <45287002+JoanneOFlynn2018@users.noreply.github.com> * Don't remove existing 'stable-1.5' generated files (#412) * Minor updates to dashboarding guide (#413) * Minor updates to dashboarding guide Perform some minor updates to the dashboarding guide, referencing existing dashboards we have for virtual machine and memcached views. Update the ServiceTelemetry manifest to reference the rhel8/grafana:7 container image which should provide more consistency in how things are deployed, helping avoid a situation where newer versions of Grafana out of hub.docker.com no longer interface with the version of Elasticsearch that would be used when enabling events support by default. Update the path to the dashboards being created to reference the 'stf-1/' directory to reduce confusion by no longer referencing stf-1.3 in the links. Depends-On: infrawatch/dashboards#50 * Update doc-Service-Telemetry-Framework/modules/con_dashboards.adoc plural to single * Update doc-Service-Telemetry-Framework/modules/proc_setting-up-grafana-to-host-the-dashboard.adoc * Add note about STF 1.3 and revert path change Revert path changes to the dashboards as use of symlinks as intended is not possible. Instead, add a note stating that the reference to STF 1.3 is the earliest version compatible with the dashboards, and can be used with STF versions 1.3 through 1.5. Co-authored-by: JoanneOFlynn2018 <45287002+JoanneOFlynn2018@users.noreply.github.com> * Fix syntax error in certificate renewal module (#416) * Fix syntax error in certificate renewal module Fix a syntax error in the certificate renewal module. Fixing this results in another issue that was hidden, whereby extra source lines are shown when building for version 17.0 due to loose version ranges. Unfortunately asciidoc doesn't provide an AND function in an ifeval or ifdef so we need separate parameters defined and nested to perform what is effectively a greater-than AND less-than evaluation. This was caught by QE when identifying a link that didn't have a corresponding section being built. The syntax error on the endif resulted in everything after that not being built, but did not result in a build error oddly enough. With this fix, everything is working as intended and included assemblies after this one are now visible. * Update ifdef to use AND syntax Update ifdef to use AND syntax per https://docs.asciidoctor.org/asciidoc/latest/directives/ifdef-ifndef/#checking-multiple-attributes * Removed sending-metrics-to-gnocchi-and-to-stf m… (#414) * Removed xrefs and include for sending-metrics-to-gnocchi-and-to-stf module * New folder named departure to hold files before deletion, updated gitignore file * I removed an assembly xref from additional resources section so that build is 100% * Removed upgrade section * Added link at assembly level re disabling services Co-authored-by: Leif Madsen <lmadsen@redhat.com> * Jof mas minor edits 1.5 (#421) * changes to Primary parameters of the ServiceTelemetry object * Minor edits mostly reducing future tense * Apply suggestions from code review Routers -> dispatch routers * Update link to STF life cycle page (#423) Update the link to the STF life cycle page and remove reference to supporting the two most recent versions of STF. This has recently changed. STF 1.4 will be supported until the EOL of OpenShift 4.8 at which point STF 1.4 will also be EOL. In the meantime STF 1.4 is now in maintenance mode (CVE fixes only, no backport of features). STF 1.5 is supported as of 4.10 and will EOL with RHOSP 17.1. * updated link (#428) * Updated path to match PR#52 in dashboard repo (#427) * Fixed alertmanager verification command (#430) * Eliminate mentions of sensubility in OSP13 (#431) * A list of low hanging docs changes from our feature testing (#426) * A list of low hanging docs changes from our feature testing Items below are from STF-1167 * OSP Connection 1a Docs: Check other containers, not just metrics_qdr * Dashboards 1c: Docs: Rewording or change object we source creds from * Dashboards 1d: Docs: Wait for grafana restart * Metrics retention 1b: Docs: Tell customers how to verify * Alerts 2: Docs: More explicit example of how to construct this config * HA 2 Docs: Improve alertmanager config docs and re-test * Continues to work for me * Ephemeral Storage Docs: Document this only upstream and/or dev docs * Observability Strategy Docs: Add a note of which objects to delete * Docs: Double check that libpodstats and sensubility are not mentioned in OSP 13 (they shouldn't be) * I checked here: https://access.redhat.com/documentation/en-us/red_hat_openstack_platform/13/html-single/service_telemetry_framework_1.5/index * libpodstats is not mentioned, but sensubility is mentioned in several places * Is this a mistake? I don't have an OSP 13 handy and haven't dug through the artifacts to figure it out. * If changes are needed, there are several affected locations, so I'll use a dedicated PR * Certificate Handling (Issue 15.1 or sooner): Set 7.5yr expiry on all certs * infrawatch/service-telemetry-operator#389 * Update doc-Service-Telemetry-Framework/modules/proc_creating-an-alert-route-with-templating-in-alertmanager.adoc Co-authored-by: Leif Madsen <lmadsen@redhat.com> * Apply suggestions from code review Co-authored-by: Leif Madsen <lmadsen@redhat.com> * Include more ceilometer agents in verification * Source block for container verif Co-authored-by: Leif Madsen <lmadsen@redhat.com> * mg_master_2161659_minor-style-edit changed note text and position (#437) Co-authored-by: Michael Geary <mgeary@redhat.com> * Remove note from importing dashboards procedure (#439) Remove the note from the importing dashboards procedure since the paths no longer refer to STF 1.3. * Adjust network polling meter for ceilometer (#440) Adjust the broad ceilometer polling meter configuration to be a bit more specific so that we aren't attempting to poll APIs that no longer exist. Closes rhbz#2129729 * Eliminate vestiges of "stf-default" (#442) * I think this used to be the default name long-long ago? * I made a deployment by cut/pasting the manifest from the ephemeral storage * And then all the names mismatched the examples and documented commands * Link to the amqp1 plugin header directly (#443) * Bump base image for building to Fedora 37 (#445) * Bump base image for building to Fedora 37 Bump the base image for building in CI to Fedora 37 because Fedora 33 is now EOL and has been removed from the quay repository. * Set /docs directory to being marked safe * Bump actions/checkout v2 (deprecated) to v3 * mg_master_2168184_adding section with procedures for upgrade from 1.4… (#444) * mg_master_2168184_adding section with procedures for upgrade from 1.4 to 1.5 * Bump base image for building to Fedora 37 (#445) * Bump base image for building to Fedora 37 Bump the base image for building in CI to Fedora 37 because Fedora 33 is now EOL and has been removed from the quay repository. * Set /docs directory to being marked safe * Bump actions/checkout v2 (deprecated) to v3 * Update doc-Service-Telemetry-Framework/assemblies/assembly_upgrading-service-telemetry-framework-to-version-1-5.adoc * commit 2, incorporating feedback mg_master_2168184_procedures-to-upgrade-from-1.4-to-1.5 * commit 3, fixed internal link to Grafana section mg_master_2168184_procedures-to-upgrade-from-1.4-to-1.5 * mg_master_2168184_procedures-to-upgrade-from-1.4-to-1.5 commit Feb 14th * Add ifdef wrappers for certificate parts (#447) * Add ifdef wrappers for certificate documentation parts which do not apply to OSP16 (only 13 and 17). * Add a couple of clean up items for consistency and visual bits. * mg_master_2168184_procedures-to-upgrade-from-1.4-to-1.5 commit Feb 17 Rebased --------- Co-authored-by: Leif Madsen <lmadsen@redhat.com> * Fix alertmanager verification command * See #430 * I missed this second instance * Revert "Fix alertmanager verification command" Accidental push to master. I will go protect the branch... This reverts commit a9aa450. * Fix alertmanager verification command (#450) * See #430 * I missed this second instance * Reference event enablement for virtual machine view (#451) * Reference event enablement for virtual machine view Reference the event enablement for the virtual machine dashboard which uses the es_ceilometer datasource. Closes: rhbz#2173856 * Soften language to make event enablement optional Soften language to make event enablement optional as suggested by Chris. * Expand supported OCP range through to 4.12 (#452) * Adjust path to triple-ansible-inventory file (#454) Adjust the path to the Ansible inventory file across RHOSP versions during documentation generation. Also fix inclusion of AMQ certificate renewal procedures in RHOSP 16 where certificate distribution does not exist. Closes: rhbz#2158178 * Remove DCN related configuration artifacts (#455) Remove DCN related configuration artifacts because it's not clear that this is helpful guidance, and there is information provided it may actually be harmful to getting a working environment. Closes: rhbz#2023902 * Add SNMP trap configuration parameters (#449) * Add SNMP trap configuration parameters Add SNMP trap configuration parameters that are being exposed via the ServiceTelemetry object. Create a concept module that provides a better overview of the OID configuration and link to location of the MIB definition. Also provide an example prometheus rule that shows how to override the OID value on a per-alert rule definition. Closes: STF-1257 * Clean up some wording * Add an example configuration manifest * Update doc-Service-Telemetry-Framework/modules/con_snmp-traps.adoc Co-authored-by: JoanneOFlynn2018 <45287002+JoanneOFlynn2018@users.noreply.github.com> * Update doc-Service-Telemetry-Framework/modules/con_snmp-traps.adoc Changing a style comment to a suggestion which I can implement * Update doc-Service-Telemetry-Framework/modules/con_snmp-traps.adoc * Update doc-Service-Telemetry-Framework/modules/con_snmp-traps.adoc * Update doc-Service-Telemetry-Framework/modules/proc_configuring-snmp-traps.adoc * Update doc-Service-Telemetry-Framework/modules/proc_configuring-snmp-traps.adoc * Update doc-Service-Telemetry-Framework/modules/proc_configuring-snmp-traps.adoc * Update doc-Service-Telemetry-Framework/modules/con_snmp-traps.adoc * Update doc-Service-Telemetry-Framework/modules/con_snmp-traps.adoc --------- Co-authored-by: JoanneOFlynn2018 <45287002+JoanneOFlynn2018@users.noreply.github.com> Co-authored-by: mickogeary <mickogeary@gmail.com> * Expose ability to set certificate renewal target times (#453) * Expose ability to set certificate renewal target times Expose the duration value in STO to allow better control of the default certificate renewal times. * Fix format errors and enhance redaction * ElasticSearch to Elasticsearch * Mispelling in default values * Inclusion of assembly for OSP 13 and OSP 16 * AQDR to {MessageBus} * Minor typo fix * Apply suggestions from code review Co-authored-by: mickogeary <mickogeary@gmail.com> --------- Co-authored-by: Leif Madsen <lmadsen@redhat.com> Co-authored-by: mickogeary <mickogeary@gmail.com> * [OSP13] Replacing "allovercloud" with "overcloud" in ansible command (#456) Co-authored-by: root <root@seal31.lab.eng.tlv2.redhat.com> * [OSP13] Replacing podman with docker in ansible command. (#457) * [OSP13] Replacing podman with docker in ansible command. * Apply suggestions from code review Co-authored-by: Leif Madsen <lmadsen@redhat.com> --------- Co-authored-by: root <root@seal31.lab.eng.tlv2.redhat.com> Co-authored-by: Leif Madsen <lmadsen@redhat.com> * Fix improper merge conflict for build_tools --------- Co-authored-by: JoanneOFlynn2018 <45287002+JoanneOFlynn2018@users.noreply.github.com> Co-authored-by: Chris Sibbitt <csibbitt@redhat.com> Co-authored-by: mickogeary <mickogeary@gmail.com> Co-authored-by: Michael Geary <mgeary@redhat.com> Co-authored-by: Victoria Martinez de la Cruz <victoria@redhat.com> Co-authored-by: Leonid Natapov <lnatapov@redhat.com> Co-authored-by: root <root@seal31.lab.eng.tlv2.redhat.com>
Merge master into stable-1.5 for STF 1.5.2 release.
leifmadsen
requested review from
ayefimov-1,
csibbitt,
elfiesmelfie,
mickogeary and
vkmc
|
This is no longer necessary as Chris and I discussed this disconnected history. I have since performed a reset against master and applied the small stable-1.5 specific changes required, and force pushed that against stable-1.5 in order to get the history back in order. I am closing this PR out as a result of that action. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.