mg master 1195 add OSPdO content incl 3 new modules #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rheslop
reviewed
May 5, 2023
...ork/modules/proc_configuring-the-stf-connection-for-director-operator-for-the-overcloud.adoc
Outdated
Show resolved
Hide resolved
rheslop
reviewed
May 5, 2023
doc-Service-Telemetry-Framework/modules/proc_deploying-the-overcloud-for-director-operator.adoc
Outdated
Show resolved
Hide resolved
…tf-connection-for-director-operator-for-the-overcloud.adoc Co-authored-by: Roger Heslop <heslop@outlook.com>
leifmadsen
reviewed
May 8, 2023
...s/proc_configuring-red-hat-openstack-platform-overcloud-for-stf-using-director-operator.adoc
Outdated
Show resolved
Hide resolved
leifmadsen
reviewed
May 8, 2023
...s/proc_configuring-red-hat-openstack-platform-overcloud-for-stf-using-director-operator.adoc
Outdated
Show resolved
Hide resolved
leifmadsen
requested changes
May 8, 2023
There was a problem hiding this comment.
Added some comments and updates to links to not have them hard-coded to the RHOSP versions. I also am thinking maybe wrapping the top level includes for this so it's generated only downstream. I'm not sure how readily available OSPdO is even upstream, and it's not important to show this in the upstream documentation for STF, in my opinion.
...ork/modules/proc_configuring-the-stf-connection-for-director-operator-for-the-overcloud.adoc
Outdated
Show resolved
Hide resolved
...ork/modules/proc_configuring-the-stf-connection-for-director-operator-for-the-overcloud.adoc
Outdated
Show resolved
Hide resolved
...ork/modules/proc_configuring-the-stf-connection-for-director-operator-for-the-overcloud.adoc
Outdated
Show resolved
Hide resolved
...ry-Framework/modules/proc_creating-the-base-configuration-for-director-operator-for-stf.adoc
Outdated
Show resolved
Hide resolved
...ry-Framework/modules/proc_creating-the-base-configuration-for-director-operator-for-stf.adoc
Outdated
Show resolved
Hide resolved
doc-Service-Telemetry-Framework/modules/proc_deploying-the-overcloud-for-director-operator.adoc
Outdated
Show resolved
Hide resolved
doc-Service-Telemetry-Framework/modules/proc_deploying-the-overcloud-for-director-operator.adoc
Outdated
Show resolved
Hide resolved
doc-Service-Telemetry-Framework/modules/proc_deploying-the-overcloud-for-director-operator.adoc
Outdated
Show resolved
Hide resolved
…rcloud-for-director-operator.adoc Co-authored-by: Roger Heslop <heslop@outlook.com>
…at-openstack-platform-overcloud-for-stf-using-director-operator.adoc
…tf-connection-for-director-operator-for-the-overcloud.adoc
…tf-connection-for-director-operator-for-the-overcloud.adoc
leifmadsen
reviewed
May 11, 2023
...s/proc_configuring-red-hat-openstack-platform-overcloud-for-stf-using-director-operator.adoc
Outdated
Show resolved
Hide resolved
…at-openstack-platform-overcloud-for-stf-using-director-operator.adoc
leifmadsen
reviewed
May 11, 2023
...s/proc_configuring-red-hat-openstack-platform-overcloud-for-stf-using-director-operator.adoc
Outdated
Show resolved
Hide resolved
…at-openstack-platform-overcloud-for-stf-using-director-operator.adoc
…tf-connection-for-director-operator-for-the-overcloud.adoc
…-configuration-for-director-operator-for-stf.adoc
…-configuration-for-director-operator-for-stf.adoc
…rcloud-for-director-operator.adoc
…rcloud-for-director-operator.adoc
…rcloud-for-director-operator.adoc
Include the rhosp_attributes file again when building for downstream. Update the Makefile so that it overrides the osp_curr_ver (which is statically set to 17.0 currently). This allows for proper URL resolution. Only build the OSPdO documentation when compiling for downstream.
leifmadsen
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.