-
Notifications
You must be signed in to change notification settings - Fork 8
Clarify topic configuration in stf-connectors.yaml #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify the topic configuration in stf-connectors.yaml so the administrator knows there is an underlying transposition happening where the topic value is transposed into a topic address, and this is the full address that would be referenced by the Smart Gateway configuration via ServiceTelemetry object, clouds parameter. Add a note that helps with understanding how the value is transposed from the provided value into the full topic address listened on the bus. Also clarify the difference between the Ceilometer configuration which as a sub-parameter called topic, and the collectd configuration that has a unique parameter name to identify the topic value. Link back to an exaple configuration to make it clear how the value is transposed into the full address. Update the linked clouds section to match our unique-cloud configuration through the document. Closes: rhbz#2189678 Closes: rhbz#2189677
mickogeary
reviewed
Jun 6, 2023
...elemetry-Framework/modules/proc_creating-openstack-environment-file-for-multiple-clouds.adoc
Outdated
Show resolved
Hide resolved
mickogeary
reviewed
Jun 6, 2023
...elemetry-Framework/modules/proc_creating-openstack-environment-file-for-multiple-clouds.adoc
Outdated
Show resolved
Hide resolved
…k-environment-file-for-multiple-clouds.adoc Co-authored-by: mickogeary <mickogeary@gmail.com>
…k-environment-file-for-multiple-clouds.adoc Co-authored-by: mickogeary <mickogeary@gmail.com>
mickogeary
reviewed
Jun 6, 2023
...rvice-Telemetry-Framework/modules/proc_configuring-the-stf-connection-for-the-overcloud.adoc
Outdated
Show resolved
Hide resolved
mickogeary
reviewed
Jun 6, 2023
...rvice-Telemetry-Framework/modules/proc_configuring-the-stf-connection-for-the-overcloud.adoc
Outdated
Show resolved
Hide resolved
…tf-connection-for-the-overcloud.adoc Co-authored-by: mickogeary <mickogeary@gmail.com>
…tf-connection-for-the-overcloud.adoc Co-authored-by: mickogeary <mickogeary@gmail.com>
mickogeary
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify the topic configuration in stf-connectors.yaml so the
administrator knows there is an underlying transposition happening where
the topic value is transposed into a topic address, and this is the full
address that would be referenced by the Smart Gateway configuration via
ServiceTelemetry object, clouds parameter.
Add a note that helps with understanding how the value is transposed
from the provided value into the full topic address listened on the bus.
Also clarify the difference between the Ceilometer configuration which
as a sub-parameter called topic, and the collectd configuration that has
a unique parameter name to identify the topic value.
Link back to an exaple configuration to make it clear how the value is
transposed into the full address. Update the linked clouds section to
match our unique-cloud configuration through the document.
Closes: rhbz#2189678
Closes: rhbz#2189677